Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: content/browser/loader/async_revalidation_manager_unittest.cc

Issue 2481093003: Introduce ResourceRequesterInfo to abstract the requester of resource request (Closed)
Patch Set: incorporated kinuko's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/async_revalidation_manager_unittest.cc
diff --git a/content/browser/loader/async_revalidation_manager_unittest.cc b/content/browser/loader/async_revalidation_manager_unittest.cc
index b06f63ce1682bfc4ffa0e1ef897d44cea8dad470..db03ed8ebf4ee5c1d58517ed945a3102a67ea3af 100644
--- a/content/browser/loader/async_revalidation_manager_unittest.cc
+++ b/content/browser/loader/async_revalidation_manager_unittest.cc
@@ -25,7 +25,6 @@
#include "content/common/resource_request.h"
#include "content/public/browser/resource_context.h"
#include "content/public/common/appcache_info.h"
-#include "content/public/common/process_type.h"
#include "content/public/common/resource_type.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -207,13 +206,13 @@ class BlackholeFilter : public ResourceMessageFilter {
explicit BlackholeFilter(ResourceContext* resource_context)
: ResourceMessageFilter(
ChildProcessHostImpl::GenerateChildProcessUniqueId(),
- PROCESS_TYPE_RENDERER,
nullptr,
nullptr,
nullptr,
nullptr,
base::Bind(&BlackholeFilter::GetContexts, base::Unretained(this))),
resource_context_(resource_context) {
+ InitializeOnIOThread();
ChildProcessSecurityPolicyImpl::GetInstance()->Add(child_id());
}
@@ -264,6 +263,8 @@ ResourceRequest CreateResourceRequest(const char* method,
return request;
}
+} // namespace
+
class AsyncRevalidationManagerTest : public ::testing::Test {
protected:
AsyncRevalidationManagerTest(
@@ -307,7 +308,7 @@ class AsyncRevalidationManagerTest : public ::testing::Test {
ResourceRequest request =
CreateResourceRequest("GET", RESOURCE_TYPE_SUB_RESOURCE, url);
ResourceHostMsg_RequestResource msg(render_view_id, request_id, request);
- host_.OnMessageReceived(msg, filter_.get());
+ filter_->OnMessageReceived(msg);
base::RunLoop().RunUntilIdle();
}
@@ -344,7 +345,7 @@ TEST_F(AsyncRevalidationManagerTest, AsyncRevalidationNotSupportedForPOST) {
ResourceRequest request = CreateResourceRequest(
"POST", RESOURCE_TYPE_SUB_RESOURCE, GURL("http://example.com/baz.php"));
ResourceHostMsg_RequestResource msg(0, 1, request);
- host_.OnMessageReceived(msg, filter_.get());
+ filter_->OnMessageReceived(msg);
base::RunLoop().RunUntilIdle();
net::URLRequest* url_request(
@@ -554,6 +555,4 @@ TEST_F(AsyncRevalidationManagerRecordingTest, NoSWRAfterFirstRedirectLeg) {
EXPECT_TRUE(IsEmpty());
}
-} // namespace
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698