Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2481033007:
[Android DomKey] Fix 7 Android DomKey mapping to match FF (Closed)
Description[Android DomKey] Fix 7 key mappings to match FF
This CL maps the following keys:
AKEYCODE_SWITCH_CHARSET (95) => "ModeChange"
AKEYCODE_FORWARD (125) => "BrowserForward"
AKEYCODE_NUMPAD_ENTER (160) => "Enter"
AKEYCODE_BOOKMARK (174) => "BrowserFavorites"
AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext"
AKEYCODE_MUHENKAN (213) => "NonConvert"
AKEYCODE_HENKAN (214) => "Convert"
See bug for more detailed explanations.
TEST=Manual
1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html
2. Focus input field
3. Run command "adb shell input keyevent 95", etc
4. Verify produced "key"
Alternatively we can add tests in
"web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map.
BUG=662372
Committed: https://crrev.com/c7c76532cc8698c31c622c3340fd0b33ec0d36e3
Cr-Commit-Position: refs/heads/master@{#431337}
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Android DomKey] Fix 7 Android DomKey mapping to match FF BUG=662372 ========== to ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" BUG=662372 ==========
Description was changed from ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" BUG=662372 ========== to ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can test those keys in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 ==========
Description was changed from ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can test those keys in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 ========== to ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can add tests in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 ==========
chongz@chromium.org changed reviewers: + dtapuska@chromium.org
dtapuska@ PTAL, thanks!
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
chongz@chromium.org changed reviewers: + wez@chromium.org
wez@ PTAL, thanks!
wez@chromium.org changed reviewers: + garykac@chromium.org - wez@chromium.org
wez -> garykac since this primarily needs review wrt the spec.
On 2016/11/09 23:11:31, Wez wrote: > wez -> garykac since this primarily needs review wrt the spec. I compared this with the info compiled in https://docs.google.com/spreadsheets/d/1YB4M5Y5BWSn-7FX7pXFNbLtDDGzQ0noUTIo-Y... and these all look good (and improve compat with FF!). I'll update that table once this lands.
lgtm
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can add tests in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 ========== to ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can add tests in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can add tests in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 ========== to ========== [Android DomKey] Fix 7 key mappings to match FF This CL maps the following keys: AKEYCODE_SWITCH_CHARSET (95) => "ModeChange" AKEYCODE_FORWARD (125) => "BrowserForward" AKEYCODE_NUMPAD_ENTER (160) => "Enter" AKEYCODE_BOOKMARK (174) => "BrowserFavorites" AKEYCODE_LANGUAGE_SWITCH (204) => "GroupNext" AKEYCODE_MUHENKAN (213) => "NonConvert" AKEYCODE_HENKAN (214) => "Convert" See bug for more detailed explanations. TEST=Manual 1. On Android go to https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html 2. Focus input field 3. Run command "adb shell input keyevent 95", etc 4. Verify produced "key" Alternatively we can add tests in "web_input_event_builders_android_unittest.cc", but I'm not sure how useful it would be since it's just a static map. BUG=662372 Committed: https://crrev.com/c7c76532cc8698c31c622c3340fd0b33ec0d36e3 Cr-Commit-Position: refs/heads/master@{#431337} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c7c76532cc8698c31c622c3340fd0b33ec0d36e3 Cr-Commit-Position: refs/heads/master@{#431337} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
