chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 2481013011: Add a page to explain earcons in the tutorial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2481013011: Add a page to explain earcons in the tutorial (Closed)

Patch Set: Undo keymap change Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index dc2fdece34394575665044b27b4eea25786baba3..b8fc57a95830b35ca63555302c951da96236d8ec 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -786,11 +786,11 @@ Background.prototype = {

}

// Next, try to focus the start or end node.

- if (isFocusableLinkOrControl(start)) {

+ if (!AutomationPredicate.structuralContainer(start)) {

if (!start.state.focused)

start.focus();

return;

- } else if (isFocusableLinkOrControl(end)) {

+ } else if (!AutomationPredicate.structuralContainer(end)) {

if (!end.state.focused)

end.focus();

return;