Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2481013010: [parser, serializer] Fix more -Wsign-compare warnings. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser, serializer] Fix more -Wsign-compare warnings. BUG=v8:5614 Committed: https://crrev.com/8ddc260d3b81eb14ba5922d46614556fe35a5e18 Cr-Commit-Position: refs/heads/master@{#40927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -87 lines) Patch
M src/parsing/scanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/scanner-character-streams.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M src/unicode.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/value-serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 45 chunks +59 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ulan
ptal
4 years, 1 month ago (2016-11-11 10:56:56 UTC) #2
vogelheim
lgtm
4 years, 1 month ago (2016-11-11 13:06:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481013010/1
4 years, 1 month ago (2016-11-11 13:51:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:53:42 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ddc260d3b81eb14ba5922d46614556fe35a5e18
Cr-Commit-Position: refs/heads/master@{#40927}

Powered by Google App Engine
This is Rietveld 408576698