Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2481013008: Delete WindowManagerWindowTreeFactorySetTestApi. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete WindowManagerWindowTreeFactorySetTestApi. This class can be trivially replaced with a simple function. It no longer has any need to be a friend class to other classes. BUG=663907 Committed: https://crrev.com/8624207f2e1fe2961f12bfeae6df773fa1e3f12e Cr-Commit-Position: refs/heads/master@{#431698}

Patch Set 1 #

Patch Set 2 : Make const ref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -103 lines) Patch
M services/ui/ws/cursor_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M services/ui/ws/display_unittest.cc View 8 chunks +12 lines, -36 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 2 chunks +4 lines, -17 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 2 chunks +6 lines, -18 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M services/ui/ws/window_manager_state_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M services/ui/ws/window_manager_window_tree_factory.h View 2 chunks +0 lines, -6 lines 0 comments Download
M services/ui/ws/window_manager_window_tree_factory_set.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
kylechar
4 years, 1 month ago (2016-11-10 18:44:10 UTC) #2
sky
Nice cleanup! LGTM
4 years, 1 month ago (2016-11-10 21:11:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481013008/20001
4 years, 1 month ago (2016-11-11 23:36:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 00:24:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 00:26:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8624207f2e1fe2961f12bfeae6df773fa1e3f12e
Cr-Commit-Position: refs/heads/master@{#431698}

Powered by Google App Engine
This is Rietveld 408576698