Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc

Issue 2481013007: Improve tracking of user initiated page loads. (Closed)
Patch Set: fix tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
index 068ee3c1d2d674963fbabc9d6a10b845fd3ca082..849be6fcc59ff5323f49e0a28a2945b5821fc6d3 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
@@ -64,7 +64,7 @@ TEST_F(AbortsPageLoadMetricsObserverTest, BackgroundBeforeCommit) {
NavigateAndCommit(GURL("about:blank"));
histogram_tester().ExpectTotalCount(
internal::kHistogramAbortBackgroundBeforeCommit, 1);
- EXPECT_EQ(1, CountTotalAbortMetricsRecorded());
+ EXPECT_EQ(2, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest,
@@ -140,7 +140,7 @@ TEST_F(AbortsPageLoadMetricsObserverTest, StopBeforeCommit) {
DeleteContents();
histogram_tester().ExpectTotalCount(internal::kHistogramAbortStopBeforeCommit,
1);
- EXPECT_EQ(1, CountTotalAbortMetricsRecorded());
+ EXPECT_EQ(2, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, StopBeforePaint) {
@@ -171,7 +171,7 @@ TEST_F(AbortsPageLoadMetricsObserverTest, StopBeforeCommitAndBeforePaint) {
1);
histogram_tester().ExpectTotalCount(internal::kHistogramAbortStopBeforePaint,
1);
- EXPECT_EQ(2, CountTotalAbortMetricsRecorded());
+ EXPECT_EQ(3, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, CloseBeforeCommit) {
@@ -180,7 +180,7 @@ TEST_F(AbortsPageLoadMetricsObserverTest, CloseBeforeCommit) {
DeleteContents();
histogram_tester().ExpectTotalCount(
internal::kHistogramAbortCloseBeforeCommit, 1);
- EXPECT_EQ(1, CountTotalAbortMetricsRecorded());
+ EXPECT_EQ(2, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, CloseBeforePaint) {
@@ -206,7 +206,7 @@ TEST_F(AbortsPageLoadMetricsObserverTest,
internal::kHistogramAbortCloseBeforeCommit, 1);
histogram_tester().ExpectTotalCount(internal::kHistogramAbortCloseBeforePaint,
1);
- EXPECT_EQ(2, CountTotalAbortMetricsRecorded());
+ EXPECT_EQ(3, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest,
@@ -222,7 +222,7 @@ TEST_F(AbortsPageLoadMetricsObserverTest,
1);
histogram_tester().ExpectTotalCount(internal::kHistogramAbortCloseBeforePaint,
1);
- EXPECT_EQ(2, CountTotalAbortMetricsRecorded());
+ EXPECT_EQ(3, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, NoAbortNewNavigationFromAboutURL) {

Powered by Google App Engine
This is Rietveld 408576698