Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6961)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2481013007: Improve tracking of user initiated page loads. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 06beda69a78a05cc10b8b946f221efe066c9d09d..10c24deeb602fe7f475b8fd9c6536416302269a1 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -71,7 +71,12 @@ const char kHistogramAbortReloadUserInitiated[] =
namespace {
bool IsAbortUserInitiated(const page_load_metrics::PageLoadExtraInfo& info) {
- return info.abort_user_initiated && info.user_gesture;
+ // We consider an abort to be user initiated if the abort was triggered by a
+ // user action, and the page load being aborted was also user initiated. A
+ // user may abort a non-user-initiated page load, but we exclude these from
+ // our user initiated abort tracking since it's less clear that such an abort
+ // is interesting from a user perspective.
+ return info.abort_user_initiated && info.user_initiated;
}
void RecordAbortBeforeCommit(UserAbortType abort_type,

Powered by Google App Engine
This is Rietveld 408576698