Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.h

Issue 2481013007: Improve tracking of user initiated page loads. (Closed)
Patch Set: fix comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.h
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.h b/chrome/browser/page_load_metrics/page_load_tracker.h
index 3d082f8e03afa7c0d96e3f9436edf8d6057e0160..b6411f71fd9ed37ffe938ad1a3fc062e92bc6d8f 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.h
+++ b/chrome/browser/page_load_metrics/page_load_tracker.h
@@ -247,9 +247,14 @@ class PageLoadTracker {
// be the first abort action the user performed.
UserAbortType abort_type_;
- // This boolean is only an approximation. As the aborts pipeline is updated,
- // more abort types will have this set to true. Currently, this is only set
- // for navigations aborting navigations.
+ // Whether the abort for this page load was user initiated. For example, if
+ // this page load was aborted by a new navigation, this field tracks whether
+ // that new navigation was user-initiated. This field is only useful if this
+ // page load's abort type is a value other than ABORT_NONE. Note that this
+ // value is currently experimental, and is subject to change. In particular,
+ // this field is never set to true for some abort types, such as stop and
+ // close, since we don't yet have sufficient instrumentation to know if a stop
+ // or close was caused by a user action.
bool abort_user_initiated_;
base::TimeTicks abort_time_;
@@ -274,7 +279,7 @@ class PageLoadTracker {
// This is derived from the user gesture bit in the renderer. For browser
// initiated navigations this will always be true.
- bool user_gesture_;
+ bool user_initiated_;
// This is a subtle member. If a provisional load A gets aborted by
// provisional load B, which gets aborted by C that eventually commits, then

Powered by Google App Engine
This is Rietveld 408576698