Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2481013006: Check that Dart_CreateIsolate is given a correct kind of snapshot. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check that Dart_CreateIsolate is given a correct kind of snapshot. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/ab26422df02927d6597ffdb04da42e4980ae3922

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -3 lines) Patch
M runtime/include/dart_api.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 1 month ago (2016-11-08 21:59:06 UTC) #2
zra
lgtm
4 years, 1 month ago (2016-11-09 00:10:04 UTC) #4
rmacnak
4 years, 1 month ago (2016-11-09 00:50:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
ab26422df02927d6597ffdb04da42e4980ae3922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698