Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2481013004:
[sensors] Reject test promise when callback throws an error (Closed)
Description[sensors] Reject test promise when callback throws an error
This CL improves test reports for ambient light sensor by wrapping
Sensor.on* callbacks that might throw an error. When error is thrown,
promise for async test is rejected and executed test would be marked
as 'FAIL'. Before this change, failing tests could timeout and block
consecutive test execution.
BUG=606766
Committed: https://crrev.com/6420f2fefc6438000fe55814cc3d18fe38096915
Cr-Commit-Position: refs/heads/master@{#430917}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fixes for comments from Mikhail #Patch Set 3 : Rebased to master #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== [sensors] Reject test promise when callback throws an error This CL improves test reports for ambient light sensor by wrapping Sensor.on* callbacks that might throw an error. When error is thrown, promise for async test is rejected and executed test would be marked as 'FAIL'. Before this change, failing tests could timeout and block consecutive test execution. BUG=606766 ========== to ========== [sensors] Reject test promise when callback throws an error This CL improves test reports for ambient light sensor by wrapping Sensor.on* callbacks that might throw an error. When error is thrown, promise for async test is rejected and executed test would be marked as 'FAIL'. Before this change, failing tests could timeout and block consecutive test execution. BUG=606766 ==========
alexander.shalamov@intel.com changed reviewers: + mikhail.pozdnyakov@intel.com
The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take a look.
https://codereview.chromium.org/2481013004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js (right): https://codereview.chromium.org/2481013004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js:15: callback() { Could you provide more readable name for it, for example 'getWrapped()'?
lgtm
The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
alexander.shalamov@intel.com changed reviewers: + haraken@chromium.org
PTAL
LGTM on my side
The CQ bit was checked by alexander.shalamov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from mikhail.pozdnyakov@intel.com Link to the patchset: https://codereview.chromium.org/2481013004/#ps40001 (title: "Rebased to master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [sensors] Reject test promise when callback throws an error This CL improves test reports for ambient light sensor by wrapping Sensor.on* callbacks that might throw an error. When error is thrown, promise for async test is rejected and executed test would be marked as 'FAIL'. Before this change, failing tests could timeout and block consecutive test execution. BUG=606766 ========== to ========== [sensors] Reject test promise when callback throws an error This CL improves test reports for ambient light sensor by wrapping Sensor.on* callbacks that might throw an error. When error is thrown, promise for async test is rejected and executed test would be marked as 'FAIL'. Before this change, failing tests could timeout and block consecutive test execution. BUG=606766 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [sensors] Reject test promise when callback throws an error This CL improves test reports for ambient light sensor by wrapping Sensor.on* callbacks that might throw an error. When error is thrown, promise for async test is rejected and executed test would be marked as 'FAIL'. Before this change, failing tests could timeout and block consecutive test execution. BUG=606766 ========== to ========== [sensors] Reject test promise when callback throws an error This CL improves test reports for ambient light sensor by wrapping Sensor.on* callbacks that might throw an error. When error is thrown, promise for async test is rejected and executed test would be marked as 'FAIL'. Before this change, failing tests could timeout and block consecutive test execution. BUG=606766 Committed: https://crrev.com/6420f2fefc6438000fe55814cc3d18fe38096915 Cr-Commit-Position: refs/heads/master@{#430917} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6420f2fefc6438000fe55814cc3d18fe38096915 Cr-Commit-Position: refs/heads/master@{#430917} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
