Issue 24810002: Yet another attempt to fix quadratic circle approximation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24810002: Yet another attempt to fix quadratic circle approximation (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
caryclark, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

This CL effectively reverts: r5997 Altered arcTo's canonical points to (usually) be convex (https://codereview.appspot.com/6709051/) r9928 GM (and fix) for drawArc capping issue (https://codereview.chromium.org/18271003/) Instead of pushing some of the on-curve points out to attain convexity, this patch pulls all the off curve points in. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11504

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -30 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/core/SkGeometry.cpp	View	1 2	3 chunks	+22 lines, -29 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

robertphillips

7 years, 2 months ago (2013-09-27 17:06:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r11504 (presubmit successful).