Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: ui/views/view.cc

Issue 2480993002: Clean up some NativeTheme code. (Closed)
Patch Set: no notreached Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/native_theme/native_theme_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first. 5 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
6 6
7 #include "ui/views/view.h" 7 #include "ui/views/view.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <cmath> 10 #include <cmath>
(...skipping 852 matching lines...) Expand 10 before | Expand all | Expand 10 after
863 const ui::ThemeProvider* View::GetThemeProvider() const { 863 const ui::ThemeProvider* View::GetThemeProvider() const {
864 const Widget* widget = GetWidget(); 864 const Widget* widget = GetWidget();
865 return widget ? widget->GetThemeProvider() : nullptr; 865 return widget ? widget->GetThemeProvider() : nullptr;
866 } 866 }
867 867
868 const ui::NativeTheme* View::GetNativeTheme() const { 868 const ui::NativeTheme* View::GetNativeTheme() const {
869 const Widget* widget = GetWidget(); 869 const Widget* widget = GetWidget();
870 if (widget) 870 if (widget)
871 return widget->GetNativeTheme(); 871 return widget->GetNativeTheme();
872 872
873 #if defined(OS_WIN) 873 return ui::NativeTheme::GetInstanceForNativeUi();
874 // On Windows, ui::NativeTheme::GetInstanceForWeb() returns NativeThemeWinAura
875 // because that's what the renderer wants, but Views should default to
876 // NativeThemeWin. TODO(estade): clean this up, see http://crbug.com/558029
877 return ui::NativeThemeWin::instance();
878 #else
879 return ui::NativeTheme::GetInstanceForWeb();
880 #endif
881 } 874 }
882 875
883 // RTL painting ---------------------------------------------------------------- 876 // RTL painting ----------------------------------------------------------------
884 877
885 void View::EnableCanvasFlippingForRTLUI(bool enable) { 878 void View::EnableCanvasFlippingForRTLUI(bool enable) {
886 flip_canvas_on_paint_for_rtl_ui_ = enable; 879 flip_canvas_on_paint_for_rtl_ui_ = enable;
887 } 880 }
888 881
889 // Input ----------------------------------------------------------------------- 882 // Input -----------------------------------------------------------------------
890 883
(...skipping 1531 matching lines...) Expand 10 before | Expand all | Expand 10 after
2422 // Message the RootView to do the drag and drop. That way if we're removed 2415 // Message the RootView to do the drag and drop. That way if we're removed
2423 // the RootView can detect it and avoid calling us back. 2416 // the RootView can detect it and avoid calling us back.
2424 gfx::Point widget_location(event.location()); 2417 gfx::Point widget_location(event.location());
2425 ConvertPointToWidget(this, &widget_location); 2418 ConvertPointToWidget(this, &widget_location);
2426 widget->RunShellDrag(this, data, widget_location, drag_operations, source); 2419 widget->RunShellDrag(this, data, widget_location, drag_operations, source);
2427 // WARNING: we may have been deleted. 2420 // WARNING: we may have been deleted.
2428 return true; 2421 return true;
2429 } 2422 }
2430 2423
2431 } // namespace views 2424 } // namespace views
OLDNEW
« no previous file with comments | « ui/native_theme/native_theme_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698