Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2480973002: Add imported/wpt/html/webappapis/idle-callbacks/cancel-invoked.html to LeakExpectations (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add imported/wpt/html/webappapis/idle-callbacks/cancel-invoked.html to LeakExpectations This test has the following leak log: ({"numberOfLiveActiveDOMObjects":[2,3]}) Example results: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_Leak/1493/layout-test-results/results.html BUG=662477 Committed: https://crrev.com/bf4581f89f3fc1368fd343ca2062218f7b0bfc7b Cr-Commit-Position: refs/heads/master@{#430173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
Hi Kent, does this seem OK to add to LeakExpectations? After this, we should decide ...
4 years, 1 month ago (2016-11-05 17:13:50 UTC) #3
tkent
lgtm
4 years, 1 month ago (2016-11-05 17:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480973002/1
4 years, 1 month ago (2016-11-05 17:31:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 18:45:20 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 18:58:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf4581f89f3fc1368fd343ca2062218f7b0bfc7b
Cr-Commit-Position: refs/heads/master@{#430173}

Powered by Google App Engine
This is Rietveld 408576698