Make Checked* functions better align with GCC/Clang intrinsics

Make Checked* functions better align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003
Committed: https://crrev.com/216b62a9bb39c9b6e5936d90b8085c300843bd9c
Cr-Commit-Position: refs/heads/master@{#430511}

[jschuh, 2016-11-05 04:39:36]

checkpoint

[jschuh, 2016-11-05 14:54:27]

compile fix

[jschuh, 2016-11-07 16:59:36]

Description was changed from

==========
Make Checked* math function prototypes align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003
==========

to

==========
Make Checked* functions better align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003
==========

[jschuh, 2016-11-07 17:17:40]

The CQ bit was checked by jschuh@chromium.org to run a CQ dry run

[jschuh, 2016-11-07 17:17:58]

jschuh@chromium.org changed reviewers:
+ tsepez@chromium.org

[jschuh, 2016-11-07 17:17:58]

ptal

[commit-bot: I haz the power, 2016-11-07 17:18:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-07 17:42:57]

lgtm

https://codereview.chromium.org/2480953002/diff/80001/base/numerics/safe_math.h
File base/numerics/safe_math.h (right):

https://codereview.chromium.org/2480953002/diff/80001/base/numerics/safe_math...
base/numerics/safe_math.h:123: bool is_valid = std::numeric_limits<T>::is_iec559
|| IsValid();
nit: maybe flip around these two lines and combine with && expression below.

https://codereview.chromium.org/2480953002/diff/80001/base/numerics/safe_math...
base/numerics/safe_math.h:222: Promotion result;                                
                         \
nit: want to assign 0 to it?  0 is a valid value of 0 for all uses of 0.

[jschuh, 2016-11-07 17:58:31]

nit

[Tom Sepez, 2016-11-07 18:01:26]

still LGTM

[jschuh, 2016-11-07 18:14:31]

nits + compile fix

[jschuh, 2016-11-07 18:16:18]

https://codereview.chromium.org/2480953002/diff/80001/base/numerics/safe_math.h
File base/numerics/safe_math.h (right):

https://codereview.chromium.org/2480953002/diff/80001/base/numerics/safe_math...
base/numerics/safe_math.h:123: bool is_valid = std::numeric_limits<T>::is_iec559
|| IsValid();
On 2016/11/07 17:42:57, Tom Sepez wrote:
> nit: maybe flip around these two lines and combine with && expression below.

Done.

https://codereview.chromium.org/2480953002/diff/80001/base/numerics/safe_math...
base/numerics/safe_math.h:222: Promotion result;                                
                         \
On 2016/11/07 17:42:57, Tom Sepez wrote:
> nit: want to assign 0 to it?  0 is a valid value of 0 for all uses of 0.

Done.

[jschuh, 2016-11-07 18:16:32]

Patchset #6 (id:100001) has been deleted

[jschuh, 2016-11-07 21:22:33]

The CQ bit was checked by jschuh@chromium.org

[jschuh, 2016-11-07 21:22:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2480953002/#ps120001
(title: "nits + compile fix")

[commit-bot: I haz the power, 2016-11-07 21:22:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 23:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:25:20]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jschuh, 2016-11-08 02:14:17]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2016-11-08 02:14:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:53:48]

Description was changed from

==========
Make Checked* functions better align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003
==========

to

==========
Make Checked* functions better align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003
==========

[commit-bot: I haz the power, 2016-11-08 03:53:50]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-11-08 04:00:12]

Description was changed from

==========
Make Checked* functions better align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003
==========

to

==========
Make Checked* functions better align with GCC/Clang intrinsics

This switches around the return types and out params.

BUG=613003

Committed: https://crrev.com/216b62a9bb39c9b6e5936d90b8085c300843bd9c
Cr-Commit-Position: refs/heads/master@{#430511}
==========

[commit-bot: I haz the power, 2016-11-08 04:00:13]

Patchset 6 (id:??) landed as
https://crrev.com/216b62a9bb39c9b6e5936d90b8085c300843bd9c
Cr-Commit-Position: refs/heads/master@{#430511}