Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2480903002: Enable overlay scrollbars on ChromeOS (Closed)

Created:
4 years, 1 month ago by bokan
Modified:
4 years, 1 month ago
Reviewers:
sky, nasko, Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable overlay scrollbars on ChromeOS BUG=307091 Committed: https://crrev.com/c3cd4454faafb5d1be7daf31570751cf127d6461 Cr-Commit-Position: refs/heads/master@{#430853}

Patch Set 1 #

Patch Set 2 : Enable overlay scrollbars on ChromeOS #

Patch Set 3 : N/A #

Patch Set 4 : Rebase #

Patch Set 5 : Fix site per process test #

Patch Set 6 : Fix site per process test #

Patch Set 7 : Use flags rather than REF #

Patch Set 8 : Fixed PhishingDOMFeatureExtractor test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M chrome/renderer/autofill/form_classifier_browsertest.cc View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/native_theme/native_theme_switches.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 41 (32 generated)
bokan
Ok, test situation is figured out in https://codereview.chromium.org/2473163002/, ptal. Sorry, I accidentally created a new ...
4 years, 1 month ago (2016-11-04 23:22:03 UTC) #7
bokan
All tests passed, ptal
4 years, 1 month ago (2016-11-08 21:04:28 UTC) #30
Evan Stade
excellent! lgtm
4 years, 1 month ago (2016-11-08 23:20:06 UTC) #31
bokan
+sky@ for chrome/renderer +nasko@ for content/browser and content/renderer
4 years, 1 month ago (2016-11-08 23:30:49 UTC) #33
sky
LGTM
4 years, 1 month ago (2016-11-09 00:25:44 UTC) #34
nasko
content/ LGTM
4 years, 1 month ago (2016-11-09 01:33:33 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480903002/140001
4 years, 1 month ago (2016-11-09 04:04:16 UTC) #37
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-11-09 04:11:43 UTC) #39
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 04:18:53 UTC) #41
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/c3cd4454faafb5d1be7daf31570751cf127d6461
Cr-Commit-Position: refs/heads/master@{#430853}

Powered by Google App Engine
This is Rietveld 408576698