Issue 24809002: Leaking locale changes is a Very Bad Idea.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24809002: Leaking locale changes is a Very Bad Idea. (Closed)

Created:
7 years, 2 months ago by Avi (use Gerrit)

Modified:
7 years, 2 months ago

Reviewers:
Lei Zhang, cbentzel, bengr (incorrect), mattm

CC:
chromium-reviews, cbentzel+watch_chromium.org, bengr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Leaking locale changes is a Very Bad Idea. BUG=298893, 298900 TEST=tests stop failing R=cbentzel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225538

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/net/client_hints_unittest.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

mattm, thestig You reviewed the original https://codereview.chromium.org/24451003/ which I'm pretty sure breaks any locale-sensitive tests ...

7 years, 2 months ago (2013-09-26 19:29:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/24809002/1

7 years, 2 months ago (2013-09-26 19:44:49 UTC) #3

Avi (use Gerrit)

Committed patchset #1 manually as r225538 (presubmit successful).

7 years, 2 months ago (2013-09-26 19:53:50 UTC) #4

bengr (incorrect)

7 years, 2 months ago (2013-09-26 20:33:15 UTC) #6

Ah, I see. Thanks!

On Thu, Sep 26, 2013 at 1:15 PM, <thestig@chromium.org> wrote:

> Doh. How did I miss that. lgtm
>
>
https://codereview.chromium.**org/24809002/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages