Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

Issue 2480863002: DCHECK that paint properties are never null (Closed)
Patch Set: dcheckmate Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
index 8ced299e119e36102b46e9c77918671274d329c0..8528137be78d62099bd41ce4e6b038e9d3fdd890 100644
--- a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
@@ -734,6 +734,12 @@ TEST_F(WebPluginContainerTest, CompositedPluginSPv2) {
static_cast<const CompositedPlugin*>(container->plugin());
std::unique_ptr<PaintController> paintController = PaintController::create();
+ PaintChunkProperties properties;
+ properties.transform = TransformPaintPropertyNode::root();
+ properties.clip = ClipPaintPropertyNode::root();
+ properties.effect = EffectPaintPropertyNode::root();
+ properties.scroll = ScrollPaintPropertyNode::root();
+ paintController->updateCurrentPaintChunkProperties(nullptr, properties);
GraphicsContext graphicsContext(*paintController);
container->paint(graphicsContext, CullRect(IntRect(10, 10, 400, 300)));
paintController->commitNewDisplayItems();
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698