DCHECK that paint properties are never null

third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintChunker.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::ElementsAre;
 
 namespace blink {
 namespace {
 
 // TODO(crbug.com/629946): The tests fail mysteriously on some Windows debug
 // bots.
 #if defined(NDEBUG) || !OS(WIN)
 
 PaintChunkProperties rootPaintChunkProperties() {
-  return PaintChunkProperties();
+  PaintChunkProperties rootProperties;
+  rootProperties.transform = TransformPaintPropertyNode::root();
+  rootProperties.clip = ClipPaintPropertyNode::root();
+  rootProperties.effect = EffectPaintPropertyNode::root();
+  rootProperties.scroll = ScrollPaintPropertyNode::root();
+  return rootProperties;
 }
 
 class PaintChunkerTest : public testing::Test {
  protected:
   void SetUp() override {
     RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true);
   }
 
   void TearDown() override { m_featuresBackup.restore(); }
 
@@ skipping 72 matching lines @@
                                              rootPaintChunkProperties())));
 }
 
 TEST_F(PaintChunkerTest, BuildMultipleChunksWithSinglePropertyChanging) {
   PaintChunker chunker;
   chunker.updateCurrentPaintChunkProperties(nullptr,
                                             rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransform;
+  PaintChunkProperties simpleTransform = rootPaintChunkProperties();
   simpleTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
 
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties anotherTransform;
+  PaintChunkProperties anotherTransform = rootPaintChunkProperties();
   anotherTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(nullptr, anotherTransform);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
   EXPECT_THAT(chunks,
               ElementsAre(PaintChunk(0, 2, nullptr, rootPaintChunkProperties()),
                           PaintChunk(2, 3, nullptr, simpleTransform),
                           PaintChunk(3, 4, nullptr, anotherTransform)));
 }
 
 TEST_F(PaintChunkerTest, BuildMultipleChunksWithDifferentPropertyChanges) {
   PaintChunker chunker;
   chunker.updateCurrentPaintChunkProperties(nullptr,
                                             rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransform;
+  PaintChunkProperties simpleTransform = rootPaintChunkProperties();
   simpleTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 0, 0, 0, 0, 0), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransformAndEffect;
+  PaintChunkProperties simpleTransformAndEffect = rootPaintChunkProperties();
   simpleTransformAndEffect.transform = simpleTransform.transform;
   simpleTransformAndEffect.effect = EffectPaintPropertyNode::create(
       EffectPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
       ClipPaintPropertyNode::root(), CompositorFilterOperations(), 0.5f);
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransformAndEffect);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransformAndEffectWithUpdatedTransform;
+  PaintChunkProperties simpleTransformAndEffectWithUpdatedTransform =
+      rootPaintChunkProperties();
   simpleTransformAndEffectWithUpdatedTransform.transform =
       TransformPaintPropertyNode::create(nullptr,
                                          TransformationMatrix(1, 1, 0, 0, 0, 0),
                                          FloatPoint3D(9, 8, 7));
   simpleTransformAndEffectWithUpdatedTransform.effect =
       EffectPaintPropertyNode::create(
           EffectPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
           ClipPaintPropertyNode::root(), CompositorFilterOperations(),
           simpleTransformAndEffect.effect->opacity());
   chunker.updateCurrentPaintChunkProperties(
@@ skipping 22 matching lines @@
 TEST_F(PaintChunkerTest, BuildChunksFromNestedTransforms) {
   // Test that "nested" transforms linearize using the following
   // sequence of transforms and display items:
   // <root xform>, <paint>, <a xform>, <paint>, <paint>, </a xform>, <paint>,
   // </root xform>
   PaintChunker chunker;
   chunker.updateCurrentPaintChunkProperties(nullptr,
                                             rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransform;
+  PaintChunkProperties simpleTransform = rootPaintChunkProperties();
   simpleTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   chunker.updateCurrentPaintChunkProperties(nullptr,
                                             rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
   EXPECT_THAT(
       chunks,
       ElementsAre(PaintChunk(0, 1, nullptr, rootPaintChunkProperties()),
                   PaintChunk(1, 3, nullptr, simpleTransform),
                   PaintChunk(3, 4, nullptr, rootPaintChunkProperties())));
 }
 
 TEST_F(PaintChunkerTest, ChangingPropertiesWithoutItems) {
   // Test that properties can change without display items being generated.
   PaintChunker chunker;
   chunker.updateCurrentPaintChunkProperties(nullptr,
                                             rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties firstTransform;
+  PaintChunkProperties firstTransform = rootPaintChunkProperties();
   firstTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(nullptr, firstTransform);
 
-  PaintChunkProperties secondTransform;
+  PaintChunkProperties secondTransform = rootPaintChunkProperties();
   secondTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(9, 8, 7, 6, 5, 4), FloatPoint3D(3, 2, 1));
   chunker.updateCurrentPaintChunkProperties(nullptr, secondTransform);
 
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
   EXPECT_THAT(chunks,
               ElementsAre(PaintChunk(0, 1, nullptr, rootPaintChunkProperties()),
                           PaintChunk(1, 2, nullptr, secondTransform)));
@@ skipping 34 matching lines @@
                           PaintChunk(6, 7, &id6, rootPaintChunkProperties())));
 }
 
 TEST_F(PaintChunkerTest, ChunkIds) {
   PaintChunker chunker;
   TestDisplayItem i1(DisplayItem::kDrawingFirst);
   DisplayItem::Id id1 = i1.getId();
   TestDisplayItemRequiringSeparateChunk i2;
   DisplayItem::Id id2 = i2.getId();
 
+  chunker.updateCurrentPaintChunkProperties(nullptr,
+                                            rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransform;
+  PaintChunkProperties simpleTransform = rootPaintChunkProperties();
   simpleTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(&id1, simpleTransform);
 
   chunker.incrementDisplayItemIndex(i1);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(i2);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   chunker.updateCurrentPaintChunkProperties(nullptr,
@@ skipping 11 matching lines @@
 }
 
 TEST_F(PaintChunkerTest, ChunkIdsSkippingCache) {
   PaintChunker chunker;
   TestDisplayItem i1(DisplayItem::kDrawingFirst);
   i1.setSkippedCache();
   DisplayItem::Id id1 = i1.getId();
   TestDisplayItemRequiringSeparateChunk i2;
   i2.setSkippedCache();
 
+  chunker.updateCurrentPaintChunkProperties(nullptr,
+                                            rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
-  PaintChunkProperties simpleTransform;
+  PaintChunkProperties simpleTransform = rootPaintChunkProperties();
   simpleTransform.transform = TransformPaintPropertyNode::create(
       nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
   chunker.updateCurrentPaintChunkProperties(&id1, simpleTransform);
 
   chunker.incrementDisplayItemIndex(i1);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
   chunker.incrementDisplayItemIndex(i2);
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   chunker.updateCurrentPaintChunkProperties(nullptr,
                                             rootPaintChunkProperties());
   chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
   Vector<PaintChunk> chunks = chunker.releasePaintChunks();
   EXPECT_THAT(
       chunks,
       ElementsAre(PaintChunk(0, 2, nullptr, rootPaintChunkProperties()),
                   PaintChunk(2, 4, nullptr, simpleTransform),
                   PaintChunk(4, 5, nullptr, simpleTransform),
                   PaintChunk(5, 6, nullptr, simpleTransform),
                   PaintChunk(6, 7, nullptr, rootPaintChunkProperties())));
 }
 
 #endif
 
 }  // namespace
 }  // namespace blink