Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/resources/settings/site_settings/usb_devices.html

Issue 2480843003: change site-settings -> usb-device to use cr-action-menu instead of paper-menu (Closed)
Patch Set: move helper function out of test function scope Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/usb_devices.html
diff --git a/chrome/browser/resources/settings/site_settings/usb_devices.html b/chrome/browser/resources/settings/site_settings/usb_devices.html
index d168dc5b009934ca8b440fc2998f95dcd654d050..a371110acb99c3658ca4eb2f41d600104c234cbf 100644
--- a/chrome/browser/resources/settings/site_settings/usb_devices.html
+++ b/chrome/browser/resources/settings/site_settings/usb_devices.html
@@ -1,8 +1,6 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper-menu-button.html">
+
<link rel="import" href="/i18n_setup.html">
<link rel="import" href="/settings_shared_css.html">
<link rel="import" href="/site_settings/site_settings_behavior.html">
@@ -22,7 +20,7 @@
}
</style>
- <template is="dom-repeat" items="[[devices]]">
+ <template is="dom-repeat" items="[[devices_]]">
<div class="site-settings-header">[[item.objectName]]</div>
<div class="list-frame menu-content vertical-list">
@@ -30,22 +28,20 @@
<div class="favicon-image"
style$="[[computeSiteIcon(item.origin)]]"></div>
<div class="middle">[[item.origin]]</div>
- <paper-menu-button>
- <paper-icon-button icon="cr:more-vert"
- class="dropdown-trigger">
- </paper-icon-button>
- <paper-menu id="actionMenu" class="dropdown-content" actionable
- on-iron-activate="onActionMenuIronActivate_"
- attr-for-selected="menu-value">
- <paper-item menu-value$="[[menuActions_.REMOVE]]" actionable>
- $i18n{handlerRemove}
- </paper-item>
- </paper-menu>
- </paper-menu-button>
+
+ <paper-icon-button icon="cr:more-vert" on-tap="showMenu_"
+ class="dropdown-trigger">
+ </paper-icon-button>
</div>
</div>
</template>
+ <dialog is="cr-action-menu">
+ <button class="dropdown-item" role="option" on-tap="onRemoveTap_" id="removeButton">
+ $i18n{handlerRemove}
+ </button>
+ </dialog>
+
</template>
<script src="usb_devices.js"></script>
</dom-module>

Powered by Google App Engine
This is Rietveld 408576698