Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/resources/settings/site_settings/usb_devices.html

Issue 2480843003: change site-settings -> usb-device to use cr-action-menu instead of paper-menu (Closed)
Patch Set: fix up usb-device tests as comments recommended on previous patches Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 3
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper -menu-button.html">
6 <link rel="import" href="/i18n_setup.html"> 4 <link rel="import" href="/i18n_setup.html">
7 <link rel="import" href="/settings_shared_css.html"> 5 <link rel="import" href="/settings_shared_css.html">
8 <link rel="import" href="/site_settings/site_settings_behavior.html"> 6 <link rel="import" href="/site_settings/site_settings_behavior.html">
9 <link rel="import" href="/site_settings/site_settings_prefs_browser_proxy.html"> 7 <link rel="import" href="/site_settings/site_settings_prefs_browser_proxy.html">
10 8
11 <dom-module id="usb-devices"> 9 <dom-module id="usb-devices">
12 <template> 10 <template>
13 <style include="settings-shared"> 11 <style include="settings-shared">
14 :host { 12 :host {
15 display: block; 13 display: block;
16 } 14 }
17 15
18 .site-settings-header { 16 .site-settings-header {
19 -webkit-margin-start: 20px; 17 -webkit-margin-start: 20px;
20 margin-bottom: 15px; 18 margin-bottom: 15px;
21 margin-top: 15px; 19 margin-top: 15px;
22 } 20 }
23 </style> 21 </style>
24 22
25 <template is="dom-repeat" items="[[devices]]"> 23 <template is="dom-repeat" items="[[devices_]]">
26 <div class="site-settings-header">[[item.objectName]]</div> 24 <div class="site-settings-header">[[item.objectName]]</div>
27 25
28 <div class="list-frame menu-content vertical-list"> 26 <div class="list-frame menu-content vertical-list">
29 <div class="list-item"> 27 <div class="list-item">
30 <div class="favicon-image" 28 <div class="favicon-image"
31 style$="[[computeSiteIcon(item.origin)]]"></div> 29 style$="[[computeSiteIcon(item.origin)]]"></div>
32 <div class="middle">[[item.origin]]</div> 30 <div class="middle">[[item.origin]]</div>
33 <paper-menu-button> 31
34 <paper-icon-button icon="cr:more-vert" 32 <paper-icon-button icon="cr:more-vert" on-tap="showMenu_"
35 class="dropdown-trigger"> 33 class="dropdown-trigger">
36 </paper-icon-button> 34 </paper-icon-button>
37 <paper-menu id="actionMenu" class="dropdown-content" actionable
38 on-iron-activate="onActionMenuIronActivate_"
39 attr-for-selected="menu-value">
40 <paper-item menu-value$="[[menuActions_.REMOVE]]" actionable>
41 $i18n{handlerRemove}
42 </paper-item>
43 </paper-menu>
44 </paper-menu-button>
45 </div> 35 </div>
46 </div> 36 </div>
47 </template> 37 </template>
48 38
39 <dialog is="cr-action-menu">
40 <button class="dropdown-item" role="option" on-tap="onRemoveTap_" id="remo ve-button">
dpapad 2016/11/09 20:32:09 Nit: s/remove-button/removeButton This way you ca
scottchen 2016/11/10 06:08:21 Done.
41 $i18n{handlerRemove}
42 </button>
43 </dialog>
44
49 </template> 45 </template>
50 <script src="usb_devices.js"></script> 46 <script src="usb_devices.js"></script>
51 </dom-module> 47 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698