change site-settings -> usb-device to use cr-action-menu instead of paper-menu

chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * An example empty pref.
  * @type {SiteSettingsPref}
  */
 var prefsEmpty = {
   defaults: {
@@ skipping 32 matching lines @@
  * A test version of SiteSettingsPrefsBrowserProxy. Provides helper methods
  * for allowing tests to know when a method was called, as well as
  * specifying mock responses.
  *
  * @constructor
  * @implements {settings.SiteSettingsPrefsBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 var TestSiteSettingsPrefsBrowserProxy = function() {
   settings.TestBrowserProxy.call(this, [
+    'fetchUsbDevices',
     'fetchZoomLevels',
     'getDefaultValueForContentType',
     'getExceptionList',
+    'removeUsbDevice',
     'removeZoomLevel',
     'resetCategoryPermissionForOrigin',
     'setCategoryPermissionForOrigin',
     'setDefaultValueForContentType',
   ]);
 
   /** @private {!SiteSettingsPref} */
   this.prefs_ = prefsEmpty;
 
   /** @private {!Array<ZoomLevelEntry>} */
   this.zoomList_ = [];
+
+  /** @private {!Array<UsbDeviceEntry>} */
+  this.usbDevices_ = [];
 };
 
 TestSiteSettingsPrefsBrowserProxy.prototype = {
   __proto__: settings.TestBrowserProxy.prototype,
 
   /**
    * Sets the prefs to use when testing.
    * @param {!SiteSettingsPref} prefs The prefs to set.
    */
   setPrefs: function(prefs) {
     this.prefs_ = prefs;
 
     // Notify all listeners that their data may be out of date.
     for (var type in settings.ContentSettingsTypes) {
       cr.webUIListenerCallback(
           'contentSettingSitePermissionChanged',
           settings.ContentSettingsTypes[type],
           '');
     }
   },
 
   /**
    * Sets the prefs to use when testing.
    * @param !Array<ZoomLevelEntry> list The zoom list to set.
    */
   setZoomList: function(list) {
     this.zoomList_ = list;
   },
 
+  /**
+   * Sets the prefs to use when testing.
+   * @param !Array<UsbDeviceEntry> list The usb device entry list to set.

[dschuyler, 2016/11/08 01:48:41]

The @param type should be in {}, like this:

* @param {!Array<UsbDeviceEntry>} list The usb device entry list to set.

[scottchen, 2016/11/09 19:20:56]

Done.

+   */
+  setUsbDevices: function(list) {
+    // Shallow copy of the passed-in array so mutation won't impact the source
+    this.usbDevices_ = list.slice();
+  },
+
   /** @override */
   setDefaultValueForContentType: function(contentType, defaultValue) {
     this.methodCalled(
         'setDefaultValueForContentType', [contentType, defaultValue]);
   },
 
   /** @override */
   getDefaultValueForContentType: function(contentType) {
     this.methodCalled('getDefaultValueForContentType', contentType);
 
@@ skipping 94 matching lines @@
   /** @override */
   fetchZoomLevels: function() {
     cr.webUIListenerCallback('onZoomLevelsChanged', this.zoomList_);
     this.methodCalled('fetchZoomLevels');
   },
 
   /** @override */
   removeZoomLevel: function(host) {
     this.methodCalled('removeZoomLevel', [host]);
   },
+
+  /** @override */
+  fetchUsbDevices: function() {
+    this.methodCalled('fetchUsbDevices');
+    return Promise.resolve(this.usbDevices_);
+  },
+
+  removeUsbDevice: function(origin, embeddingOrigin, object) {

[dschuyler, 2016/11/08 01:48:41]

@param for each parameter.

[dpapad, 2016/11/08 01:53:49]

Why do you need to have any logic inside here?

[scottchen, 2016/11/09 19:20:56]

The intention was to mimic the expected remove logic, in order to test that the
removeButton is sending the correct parameters from the device that triggered
the remove. 
But now to think of it, there's probably some other way to capture the param it
intends to pass and do assert on that instead. 

I'll look into it.

[scottchen, 2016/11/09 19:20:56]

Acknowledged.

+    for(var i = 0; i < this.usbDevices_.length; i++) {
+      var device = this.usbDevices_[i];
+      if(device.origin === origin
+          && device.embeddingOrigin === embeddingOrigin
+          && device.object === object) {
+        this.usbDevices_.splice(i, 1);
+        break;
+      }
+    }
+  }
 };