change site-settings -> usb-device to use cr-action-menu instead of paper-menu

chrome/browser/resources/settings/site_settings/usb_devices.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'usb-devices' is the polymer element for showing the USB Devices category
  * under Site Settings.
  */
 
 Polymer({
   is: 'usb-devices',
 
   behaviors: [SiteSettingsBehavior],
 
   properties: {
     /**
      * A list of all USB devices.
      * @type {Array<UsbDeviceEntry>}
      */
     devices: Array,

[dpapad, 2016/11/08 01:53:49]

!Array<!UsbDeviceEntry>

Also, can we turn this into a private member variable instead?

[scottchen, 2016/11/09 19:20:56]

Done.

+    /**

[dschuyler, 2016/11/08 01:48:41]

Please add a blank line before the /**.

[scottchen, 2016/11/09 19:20:56]

Done.

+     * The targetted object for menu operations.
+     * @type {?Object}
+     */
+    actionMenuModel: Object

[dpapad, 2016/11/08 01:53:49]

Since this is only used within this file, let's do the following

/**
 * The ...
 * @private {?Object}
 */
actionMenuModel_: Object,

[scottchen, 2016/11/09 19:20:56]

Done.

   },
 
   ready: function() {
     this.fetchUsbDevices_();
   },
 
   /**
    * Fetch the list of USB devices and update the list.
    * @private
    */
   fetchUsbDevices_: function() {
     this.browserProxy.fetchUsbDevices().then(function(deviceList) {
       this.devices = deviceList;
     }.bind(this));
   },
 
   /**
    * A handler when an action is selected in the action menu.
    * @param {!{model: !{item: UsbDeviceEntry}}} event
    * @private
    */
-  onActionMenuIronActivate_: function(event) {
-    var item = event.model.item;
+  onRemoveTap_: function(event) {

[dpapad, 2016/11/08 01:53:49]

|event| is no longer used in this method, let's remove it.

[scottchen, 2016/11/09 19:20:56]

Done.

+    var item = this.actionMenuModel;
     this.browserProxy.removeUsbDevice(
         item.origin, item.embeddingOrigin, item.object);
+    this.actionMenuModel = null;
     this.fetchUsbDevices_();
   },

[dschuyler, 2016/11/08 01:48:40]

Please add a blank line here.

[dpapad, 2016/11/08 01:53:49]

Add a blank line between functions.

[scottchen, 2016/11/09 19:20:56]

Done.

[scottchen, 2016/11/09 19:20:56]

Done.

+  showMenu_: function(event) {

[dschuyler, 2016/11/08 01:48:41]

Please add an @param for |event|.
Something like this with the 'example' bits changed
to something better:

/**
 * Example description.
 * @param {example_type} event
 */

[dpapad, 2016/11/08 01:53:49]

Need @private and @param annotation.

[scottchen, 2016/11/09 19:20:56]

Done.

[scottchen, 2016/11/09 19:20:56]

Done.

+    this.actionMenuModel = event.model.item;
+    /** @type {!CrActionMenuElement} */ (
+        this.$$('dialog[is=cr-action-menu]')).showAt(
+            /** @type {!Element} */ (
+                Polymer.dom(/** @type {!Event} */ (event)).localTarget));
+  }
 });