Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 248083002: Make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/24385… (Closed)

Created:
6 years, 8 months ago by reed1
Modified:
6 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)" associated chrome change (to be committed with DEPS roll) https://codereview.chromium.org/248693002/ This reverts commit bfaceb53f58c9625b5471fcff35b5ca9ca3ae29c. TBR=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=14321

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : need to define SK_SUPPORT_LEGACY_DRAWTEXT_VIRTUAL in chrome's gyp #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -249 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 6 chunks +25 lines, -4 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +9 lines, -13 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +8 lines, -10 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 2 chunks +8 lines, -10 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 2 chunks +8 lines, -10 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 2 chunks +8 lines, -10 lines 0 comments Download
M src/core/SkBBoxRecord.h View 3 chunks +8 lines, -10 lines 0 comments Download
M src/core/SkBBoxRecord.cpp View 6 chunks +11 lines, -12 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +35 lines, -19 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 4 chunks +8 lines, -12 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 6 chunks +16 lines, -20 lines 0 comments Download
M src/record/SkRecorder.h View 2 chunks +19 lines, -19 lines 0 comments Download
M src/record/SkRecorder.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +8 lines, -11 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 3 chunks +8 lines, -14 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
The CQ bit was checked by reed@google.com
6 years, 8 months ago (2014-04-23 03:35:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/248083002/60001
6 years, 8 months ago (2014-04-23 03:35:40 UTC) #2
reed1
6 years, 8 months ago (2014-04-23 04:00:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 manually as r14321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698