Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2480783002: exo: Connect frame callbacks with UI compositor begin frames. (Closed)

Created:
4 years, 1 month ago by reveman
Modified:
4 years, 1 month ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Connect frame callbacks with UI compositor begin frames. Frame callbacks are used by simple wayland clients to drive animations and provide back-pressure when producing frames. This makes use of begin frame callbacks and the frame timestamps they provide instead of having these callbacks fire at "WillDraw" time using the current time. The result is better timestamps for animations and frames that are better aligned with UI compositor drawing. BUG=661010 TEST=wayland-motion-events Committed: https://crrev.com/15aee286dd3b89eb397ff75eda58eafdaf9ad6fd Cr-Commit-Position: refs/heads/master@{#429968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -32 lines) Patch
M components/exo/surface.h View 7 chunks +37 lines, -12 lines 0 comments Download
M components/exo/surface.cc View 9 chunks +75 lines, -20 lines 0 comments Download
M components/exo/wayland/clients/motion_events.cc View 6 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reveman
4 years, 1 month ago (2016-11-04 16:38:54 UTC) #2
Daniele Castagna
lgtm
4 years, 1 month ago (2016-11-04 18:09:58 UTC) #3
Daniele Castagna
On 2016/11/04 at 18:09:58, Daniele Castagna wrote: > lgtm Can you open a bug for ...
4 years, 1 month ago (2016-11-04 18:10:22 UTC) #4
reveman
On 2016/11/04 at 18:10:22, dcastagna wrote: > On 2016/11/04 at 18:09:58, Daniele Castagna wrote: > ...
4 years, 1 month ago (2016-11-04 18:12:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480783002/1
4 years, 1 month ago (2016-11-04 18:13:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 19:09:47 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 19:18:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15aee286dd3b89eb397ff75eda58eafdaf9ad6fd
Cr-Commit-Position: refs/heads/master@{#429968}

Powered by Google App Engine
This is Rietveld 408576698