Remove NativeScrollBar*.

Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605
Committed: https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008
Cr-Commit-Position: refs/heads/master@{#430316}

[Evan Stade, 2016-11-05 00:58:22]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 00:59:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-05 01:03:56]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 01:03:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-05 01:05:07]

Description was changed from

==========
Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605
==========

to

==========
Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605
==========

[Evan Stade, 2016-11-05 01:05:07]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-11-05 02:07:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 02:07:47]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-07 16:22:55]

LGTM

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/scroll_bar_views.cc (right):

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
ui/views/controls/scrollbar/scroll_bar_views.cc:290: if (IsHorizontal()) {
optional: for consistency move the horizontal branch to
GetHorizontalScrollBarHeight.

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/scroll_bar_views.h (right):

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
ui/views/controls/scrollbar/scroll_bar_views.h:23: class VIEWS_EXPORT
ScrollBarViews : public BaseScrollBar,
optional: name this ScrollBar (the Views name is no longer meaningful and
redundant with the package).

[Evan Stade, 2016-11-07 17:10:00]

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/scroll_bar_views.cc (right):

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
ui/views/controls/scrollbar/scroll_bar_views.cc:290: if (IsHorizontal()) {
done

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/scroll_bar_views.h (right):

https://codereview.chromium.org/2480763005/diff/40001/ui/views/controls/scrol...
ui/views/controls/scrollbar/scroll_bar_views.h:23: class VIEWS_EXPORT
ScrollBarViews : public BaseScrollBar,
On 2016/11/07 16:22:55, sky wrote:
> optional: name this ScrollBar (the Views name is no longer meaningful and
> redundant with the package).

yea, this name isn't great, but ScrollBar is already taken :~(

[Evan Stade, 2016-11-07 17:10:04]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-11-07 17:10:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2480763005/#ps60001
(title: "GetHorizontalSrollBarHeight")

[commit-bot: I haz the power, 2016-11-07 17:10:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-07 17:13:03]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:13:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-07 17:22:26]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-11-07 17:22:31]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 18:11:36]

Description was changed from

==========
Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605
==========

to

==========
Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605
==========

[commit-bot: I haz the power, 2016-11-07 18:11:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-07 18:14:40]

Description was changed from

==========
Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605
==========

to

==========
Remove NativeScrollBar*.

NativeScrollBar used to wrap NativeScrollBarViews, but it was almost
entirely a pass-through shim. Thus, now we just have one layer of views
scrollbars called ScrollBarViews.

BUG=662605

Committed: https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008
Cr-Commit-Position: refs/heads/master@{#430316}
==========

[commit-bot: I haz the power, 2016-11-07 18:14:41]

Patchset 4 (id:??) landed as
https://crrev.com/4c40d5ad5f0814c514aa366e4b8cb9e7218dc008
Cr-Commit-Position: refs/heads/master@{#430316}