Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2480753003: Use a new flag to control showing "DOWNLOAD PAGE LATER" in error pages (Closed)
Patch Set: Update histogram for about unittest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/error_page/common/localized_error.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1629 matching lines...) Expand 10 before | Expand all | Expand 10 after
1640 IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid, 1640 IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid,
1641 MULTI_VALUE_TYPE(kProgressBarAnimationChoices)}, 1641 MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
1642 {"progress-bar-completion", IDS_FLAGS_PROGRESS_BAR_COMPLETION_NAME, 1642 {"progress-bar-completion", IDS_FLAGS_PROGRESS_BAR_COMPLETION_NAME,
1643 IDS_FLAGS_PROGRESS_BAR_COMPLETION_DESCRIPTION, kOsAndroid, 1643 IDS_FLAGS_PROGRESS_BAR_COMPLETION_DESCRIPTION, kOsAndroid,
1644 MULTI_VALUE_TYPE(kProgressBarCompletionChoices)}, 1644 MULTI_VALUE_TYPE(kProgressBarCompletionChoices)},
1645 #endif // OS_ANDROID 1645 #endif // OS_ANDROID
1646 #if defined(OS_ANDROID) 1646 #if defined(OS_ANDROID)
1647 {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME, 1647 {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME,
1648 IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid, 1648 IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid,
1649 FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)}, 1649 FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)},
1650 {"offline-pages-async-download",
1651 IDS_FLAGS_OFFLINE_PAGES_ASYNC_DOWNLOAD_NAME,
1652 IDS_FLAGS_OFFLINE_PAGES_ASYNC_DOWNLOAD_DESCRIPTION, kOsAndroid,
1653 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesAsyncDownloadFeature)},
1650 {"offline-pages-background-loading", 1654 {"offline-pages-background-loading",
1651 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME, 1655 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
1652 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid, 1656 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
1653 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)}, 1657 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)},
1654 {"offline-pages-sharing", IDS_FLAGS_OFFLINE_PAGES_SHARING_NAME, 1658 {"offline-pages-sharing", IDS_FLAGS_OFFLINE_PAGES_SHARING_NAME,
1655 IDS_FLAGS_OFFLINE_PAGES_SHARING_DESCRIPTION, kOsAndroid, 1659 IDS_FLAGS_OFFLINE_PAGES_SHARING_DESCRIPTION, kOsAndroid,
1656 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)}, 1660 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)},
1657 {"background-loader-for-downloads", 1661 {"background-loader-for-downloads",
1658 IDS_FLAGS_BACKGROUND_LOADER_FOR_DOWNLOADS_NAME, 1662 IDS_FLAGS_BACKGROUND_LOADER_FOR_DOWNLOADS_NAME,
1659 IDS_FLAGS_BACKGROUND_LOADER_FOR_DOWNLOADS_DESCRIPTION, kOsAndroid, 1663 IDS_FLAGS_BACKGROUND_LOADER_FOR_DOWNLOADS_DESCRIPTION, kOsAndroid,
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
2298 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2302 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2299 2303
2300 const FeatureEntry* GetFeatureEntries(size_t* count) { 2304 const FeatureEntry* GetFeatureEntries(size_t* count) {
2301 *count = arraysize(kFeatureEntries); 2305 *count = arraysize(kFeatureEntries);
2302 return kFeatureEntries; 2306 return kFeatureEntries;
2303 } 2307 }
2304 2308
2305 } // namespace testing 2309 } // namespace testing
2306 2310
2307 } // namespace about_flags 2311 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/error_page/common/localized_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698