Window prerequisites for ShelfWindowWatcher panel support.

Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Committed: https://crrev.com/dc8a06bc0baa4e557ec6ce76470b9bce68209d93
Cr-Original-Commit-Position: refs/heads/master@{#430182}
Cr-Commit-Position: refs/heads/master@{#430784}

[msw, 2016-11-04 17:36:50]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:37:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-11-04 17:44:44]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-11-04 17:44:59]

Hey Scott, please take a look; thanks!

[commit-bot: I haz the power, 2016-11-04 17:45:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:03:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-11-04 20:07:06]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=NONE
R=sky@chromium.org
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=NONE
R=sky@chromium.org
==========

[msw, 2016-11-04 20:07:29]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-11-04 20:07:38]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=NONE
R=sky@chromium.org
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=NONE
R=sky@chromium.org,reveman@chromium.org
==========

[msw, 2016-11-04 20:07:38]

msw@chromium.org changed reviewers:
+ reveman@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-11-04 20:08:18]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=NONE
R=sky@chromium.org,reveman@chromium.org
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org
==========

[msw, 2016-11-04 20:08:52]

+reveman for components/exo, please take a look; thanks!

[sky, 2016-11-04 22:14:30]

LGTM

[commit-bot: I haz the power, 2016-11-04 22:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:41:57]

Dry run: This issue passed the CQ dry run.

[msw, 2016-11-04 22:53:36]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 23:08:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 23:08:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reveman, 2016-11-05 01:25:52]

components/exo lgtm % nit

https://codereview.chromium.org/2480713003/diff/60001/components/exo/shell_su...
File components/exo/shell_surface.h (left):

https://codereview.chromium.org/2480713003/diff/60001/components/exo/shell_su...
components/exo/shell_surface.h:132: void SetApplicationId(const std::string&
application_id);
nit: can you keep this non-static function around? I prefer having a
ShellSurface API that is as close as possible to the wayland shell surface
interface and not having to deal with things like widgets in the wayland code if
possible.

[msw, 2016-11-05 23:12:08]

https://codereview.chromium.org/2480713003/diff/60001/components/exo/shell_su...
File components/exo/shell_surface.h (left):

https://codereview.chromium.org/2480713003/diff/60001/components/exo/shell_su...
components/exo/shell_surface.h:132: void SetApplicationId(const std::string&
application_id);
On 2016/11/05 01:25:52, reveman wrote:
> nit: can you keep this non-static function around? I prefer having a
> ShellSurface API that is as close as possible to the wayland shell surface
> interface and not having to deal with things like widgets in the wayland code
if
> possible.

Done.

[msw, 2016-11-05 23:12:14]

The CQ bit was checked by msw@chromium.org

[msw, 2016-11-05 23:12:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2480713003/#ps80001
(title: "Restore non-static ShellSurface::SetApplicationId.")

[commit-bot: I haz the power, 2016-11-05 23:12:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 03:54:53]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org
==========

[commit-bot: I haz the power, 2016-11-06 03:54:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-06 03:59:07]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}
==========

[commit-bot: I haz the power, 2016-11-06 03:59:08]

Patchset 5 (id:??) landed as
https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}

[hidehiko, 2016-11-08 01:02:35]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2479353003/ by hidehiko@chromium.org.

The reason for reverting is: This CL breaks the ARC launch.

The problematic part was

void ShellSurface::SetApplicationId(const std::string& application_id) {
  SetApplicationId(widget_->GetNativeWindow(), application_id);
}

where |widget_| can be null.

BUG=b/32718618
TEST=Made sure ARC starts on local dev env..

[msw, 2016-11-08 02:19:35]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}
==========

[msw, 2016-11-08 02:19:35]

msw@chromium.org changed reviewers:
+ hidehiko@chromium.org

[msw, 2016-11-08 02:29:56]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 02:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-11-08 02:34:47]

Hey reveman, please take another look; I updated exo for b/32718618.

[commit-bot: I haz the power, 2016-11-08 03:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 03:21:07]

Dry run: This issue passed the CQ dry run.

[msw, 2016-11-09 00:06:37]

I was finally able to test this on a device. My old patch crashes when loading
the Play Store, my new patch does not. The latest changes seems straightforward
enough that I can TBR the diff for reveman to peruse later; re-landing.

[msw, 2016-11-09 00:06:48]

The CQ bit was checked by msw@chromium.org

[msw, 2016-11-09 00:06:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2480713003/#ps100001
(title: "Support and test pre-widget exo ShellSurface::SetApplicationId.")

[commit-bot: I haz the power, 2016-11-09 00:07:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:13:55]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}
==========

[commit-bot: I haz the power, 2016-11-09 00:13:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-09 00:22:18]

Description was changed from

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Cr-Commit-Position: refs/heads/master@{#430182}
==========

to

==========
Window prerequisites for ShelfWindowWatcher panel support.

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
Committed: https://crrev.com/dc8a06bc0baa4e557ec6ce76470b9bce68209d93
Cr-Original-Commit-Position: refs/heads/master@{#430182}
Cr-Commit-Position: refs/heads/master@{#430784}
==========

[commit-bot: I haz the power, 2016-11-09 00:22:19]

Patchset 6 (id:??) landed as
https://crrev.com/dc8a06bc0baa4e557ec6ce76470b9bce68209d93
Cr-Commit-Position: refs/heads/master@{#430784}