Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2480653002: Remove unused pubsub stuff (Closed)

Created:
4 years, 1 month ago by smut
Modified:
4 years, 1 month ago
Reviewers:
ryanmartens
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -376 lines) Patch
M appengine/gce-backend/README.md View 1 chunk +0 lines, -6 lines 0 comments Download
M appengine/gce-backend/app.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
M appengine/gce-backend/catalog.py View 2 chunks +0 lines, -3 lines 4 comments Download
M appengine/gce-backend/handlers_cron.py View 3 chunks +0 lines, -10 lines 0 comments Download
M appengine/gce-backend/handlers_queues.py View 3 chunks +0 lines, -11 lines 0 comments Download
M appengine/gce-backend/instances.py View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/gce-backend/pubsub.py View 1 chunk +0 lines, -167 lines 0 comments Download
D appengine/gce-backend/pubsub_test.py View 1 chunk +0 lines, -170 lines 0 comments Download
M appengine/gce-backend/queue.yaml View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
smut
See the bug for more context, but basically GCE Backend no longer requires Pub/Sub.
4 years, 1 month ago (2016-11-04 00:13:12 UTC) #2
ryanmartens
lgtm with some minor comments. It's nice to simplify the deployment a bit :) https://codereview.chromium.org/2480653002/diff/1/appengine/gce-backend/catalog.py ...
4 years, 1 month ago (2016-11-04 14:02:52 UTC) #3
smut
https://codereview.chromium.org/2480653002/diff/1/appengine/gce-backend/catalog.py File appengine/gce-backend/catalog.py (left): https://codereview.chromium.org/2480653002/diff/1/appengine/gce-backend/catalog.py#oldcode39 appengine/gce-backend/catalog.py:39: 'backend_topic': pubsub.get_machine_provider_topic(), On 2016/11/04 14:02:52, ryanmartens wrote: > We ...
4 years, 1 month ago (2016-11-04 21:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480653002/1
4 years, 1 month ago (2016-11-04 22:16:13 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:18:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/e3fbb1f5dafa59a2c57cf3a9fe3708f4309ab653

Powered by Google App Engine
This is Rietveld 408576698