Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: services/service_manager/tests/lifecycle/app_client.cc

Issue 2480603004: Service Manager: Implement graceful service termination (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/tests/lifecycle/app_client.cc
diff --git a/services/service_manager/tests/lifecycle/app_client.cc b/services/service_manager/tests/lifecycle/app_client.cc
index 71d7c413ae230441adf7bda6cf2109892bb54a75..905260cf55fbc39775d0e8ae2d23ccd10d550d34 100644
--- a/services/service_manager/tests/lifecycle/app_client.cc
+++ b/services/service_manager/tests/lifecycle/app_client.cc
@@ -25,6 +25,11 @@ bool AppClient::OnConnect(const ServiceInfo& remote_info,
return true;
}
+bool AppClient::OnStop() {
+ base::MessageLoop::current()->QuitWhenIdle();
+ return true;
+}
+
void AppClient::Create(const Identity& remote_identity,
mojom::LifecycleControlRequest request) {
bindings_.AddBinding(this, std::move(request));
@@ -35,7 +40,7 @@ void AppClient::Ping(const PingCallback& callback) {
}
void AppClient::GracefulQuit() {
- base::MessageLoop::current()->QuitWhenIdle();
+ context_->RequestQuit();
}
void AppClient::Crash() {
@@ -53,7 +58,7 @@ void AppClient::CloseServiceManagerConnection() {
void AppClient::BindingLost() {
if (bindings_.empty())
- GracefulQuit();
+ OnStop();
}
} // namespace test

Powered by Google App Engine
This is Rietveld 408576698