Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2480603003:
[MD Settings][People] Fixes take picture button disappearing on page refresh (Closed)
|
Created:
4 years, 1 month ago by Moe Modified:
4 years, 1 month ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD Settings][People] Fixes take picture button disappearing on page refresh
BUG=660835
Committed: https://crrev.com/7fb78619cd5e3989365ac8763887f83ad4e1acd8
Cr-Commit-Position: refs/heads/master@{#430272}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed comment #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mahmadi@chromium.org changed reviewers: + stevenjb@chromium.org
Hi Steven, Please review this CL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
https://codereview.chromium.org/2480603003/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc (right): https://codereview.chromium.org/2480603003/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc:124: content::NotificationService::AllSources()); nit: start observing here https://codereview.chromium.org/2480603003/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc:128: registrar_.RemoveAll(); nit: stop observing here
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thank you. https://codereview.chromium.org/2480603003/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc (right): https://codereview.chromium.org/2480603003/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc:124: content::NotificationService::AllSources()); On 2016/11/04 22:57:38, Dan Beam wrote: > nit: start observing here Done. https://codereview.chromium.org/2480603003/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc:128: registrar_.RemoveAll(); On 2016/11/04 22:57:38, Dan Beam wrote: > nit: stop observing here Done.
The CQ bit was checked by mahmadi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2480603003/#ps20001 (title: "Addressed comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD Settings][People] Fixes take picture button disappearing on page refresh BUG=660835 ========== to ========== [MD Settings][People] Fixes take picture button disappearing on page refresh BUG=660835 Committed: https://crrev.com/7fb78619cd5e3989365ac8763887f83ad4e1acd8 Cr-Commit-Position: refs/heads/master@{#430272} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7fb78619cd5e3989365ac8763887f83ad4e1acd8 Cr-Commit-Position: refs/heads/master@{#430272} |
