appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py - Issue 2480593002: [Predator] Move time_util from common/ to lib/, split code review related part to code_review_util

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

Issue 2480593002: [Predator] Move time_util from common/ to lib/, split code review related part to code_review_util (Closed)

Patch Set: Rebase and fix nits. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/flake/recursive_flake_pipeline.py ('k') | appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

diff --git a/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py b/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

index 617ce22052834b2797d3dbf229370f04126f0412..9b43ef2a6138de4110792aa6418f228ad76e2035 100644

--- a/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

+++ b/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

@@ -60,7 +60,7 @@ class RecursiveFlakePipelineTest(wf_testcase.WaterfallTestCase):

mocked_utc_now = datetime(2016, 9, 04, 20, 0, 0, 0)

self.MockUTCNow(mocked_utc_now)

self.MockUTCNowWithTimezone(mocked_utc_now)

- with mock.patch('common.time_util.GetDatetimeInTimezone') as timezone_func:

+ with mock.patch('lib.time_util.GetDatetimeInTimezone') as timezone_func:

timezone_func.side_effect = [mocked_pst_now, None]

self.assertEqual(mocked_utc_now,

recursive_flake_pipeline._GetETAToStartAnalysis(False))

@@ -71,7 +71,7 @@ class RecursiveFlakePipelineTest(wf_testcase.WaterfallTestCase):

mocked_utc_now = datetime(2016, 9, 20, 8, 0, 0, 0)

self.MockUTCNow(mocked_utc_now)

self.MockUTCNowWithTimezone(mocked_utc_now)

- with mock.patch('common.time_util.GetDatetimeInTimezone') as timezone_func:

+ with mock.patch('lib.time_util.GetDatetimeInTimezone') as timezone_func:

timezone_func.side_effect = [mocked_pst_now, None]

self.assertEqual(mocked_utc_now,

recursive_flake_pipeline._GetETAToStartAnalysis(False))

@@ -86,7 +86,7 @@ class RecursiveFlakePipelineTest(wf_testcase.WaterfallTestCase):

mocked_utc_eta = datetime(2016, 9, 21, 1, 0, 0, 0) # Without delay.

self.MockUTCNow(mocked_utc_now)

self.MockUTCNowWithTimezone(mocked_utc_now)

- with mock.patch('common.time_util.GetDatetimeInTimezone') as (

+ with mock.patch('lib.time_util.GetDatetimeInTimezone') as (

timezone_func), mock.patch('random.randint') as random_func:

timezone_func.side_effect = [mocked_pst_now, mocked_utc_eta]

random_func.side_effect = [seconds_delay, None]