Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1771)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2480593002: [Predator] Move time_util from common/ to lib/, split code review related part to code_review_util (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/common/time_util.py ('k') | appengine/findit/crash/findit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 46b5a14ceafd16a1e8d0477ba305598d3cd8165c..b75829388adf3a2f57312f4c1f82979a6a67dc2e 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -8,13 +8,13 @@ import logging
from common import appengine_util
from common import pubsub_util
-from common import time_util
from common.http_client_appengine import HttpClientAppengine
from common.pipeline_wrapper import BasePipeline
from common.pipeline_wrapper import pipeline
from crash import findit_for_chromecrash
from crash import findit_for_clusterfuzz
from crash.type_enums import CrashClient
+from lib import time_util
from lib.gitiles import gitiles_repository
from model import analysis_status
@@ -115,7 +115,9 @@ class CrashAnalysisPipeline(CrashBasePipeline):
analysis.status = analysis_status.ERROR
analysis.put()
- def run(self, *_args, **_kwargs):
+ # TODO(http://crbug.com/659346): we misplaced the coverage test; find it!
+ # Arguments number differs from overridden method - pylint: disable=W0221
+ def run(self, *_args, **_kargs):
stgao 2016/11/03 22:14:05 nit: _kwargs
Sharu Jiang 2016/11/04 01:02:35 Done.
"""Call predator to do the analysis of the given crash.
N.B., due to the structure of AppEngine pipelines, this method must
« no previous file with comments | « appengine/findit/common/time_util.py ('k') | appengine/findit/crash/findit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698