[Predator] Move time_util from common/ to lib/, split code review related part to code_review_util

appengine/findit/crash/crash_pipeline.py

Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 9532858384a378b823d50d401baf93fd03345739..10d6f6d296dd1b6dbdeb4298af35f840809759e4 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -8,13 +8,13 @@ import logging
 
 from common import appengine_util
 from common import pubsub_util
-from common import time_util
 from common.http_client_appengine import HttpClientAppengine
 from common.pipeline_wrapper import BasePipeline
 from common.pipeline_wrapper import pipeline
 from crash import findit_for_chromecrash
 from crash import findit_for_clusterfuzz
 from crash.type_enums import CrashClient
+from lib import time_util
 from lib.gitiles import gitiles_repository
 from model import analysis_status
 
@@ -107,7 +107,7 @@ class CrashAnalysisPipeline(CrashBasePipeline):
 
   # TODO(http://crbug.com/659346): we misplaced the coverage test; find it!
   # Arguments number differs from overridden method - pylint: disable=W0221
-  def run(self):
+  def run(self, *_args, **_kargs):

[wrengr, 2016/11/03 22:17:58]

Hrm, this should've been fixed in the landed version of 2455053004 (along with
adding a docstring explaining why the arguments are discarded). Can you rebase?

[Sharu Jiang, 2016/11/04 01:02:34]

Done.

     # TODO(wrengr): shouldn't this method somehow call _NeedsNewAnalysis
     # to guard against race conditions?
     analysis = self._findit.GetAnalysis(self._crash_identifiers)
@@ -152,7 +152,7 @@ class PublishResultPipeline(CrashBasePipeline):
                     repr(self._crash_identifiers), self.client_id)
 
   # Arguments number differs from overridden method - pylint: disable=W0221
-  def run(self):
+  def run(self, *_args, **_kargs):

[wrengr, 2016/11/03 22:17:58]

ditto

[Sharu Jiang, 2016/11/04 01:02:34]

Done.

     analysis = self._findit.GetAnalysis(self._crash_identifiers)
     result = analysis.ToPublishableResult(self._crash_identifiers)
     messages_data = [json.dumps(result, sort_keys=True)]
@@ -185,7 +185,7 @@ class CrashWrapperPipeline(BasePipeline):
 
   # TODO(http://crbug.com/659346): write coverage tests.
   # Arguments number differs from overridden method - pylint: disable=W0221
-  def run(self): # pragma: no cover
+  def run(self, *_args, **_kargs): # pragma: no cover

[wrengr, 2016/11/03 22:17:58]

ditto

[Sharu Jiang, 2016/11/04 01:02:34]

Done.

     run_analysis = yield CrashAnalysisPipeline(
         self._client_id, self._crash_identifiers)
     with pipeline.After(run_analysis):