[Predator] Move time_util from common/ to lib/, split code review related part to code_review_util

appengine/findit/lib/gitiles/test/gitiles_repository_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 from datetime import datetime
 import json
 import re
 
 from testing_utils import testing
@@ skipping 280 matching lines @@
     self.repo_url = 'https://repo.test'
     self.git_repo = gitiles_repository.GitilesRepository(self.repo_url,
                                                  self.http_client_for_git)
 
   def testGitRepositoryPropertySetters(self):
     http_client_for_git = HttpClientForGit()
     git_repo = gitiles_repository.GitilesRepository(
         http_client=http_client_for_git)
     git_repo.repo_url = 'https://repo'
     self.assertEqual(git_repo.repo_url, 'https://repo')
-
     self.assertEqual(git_repo. http_client, http_client_for_git)
 
-  def testExtractCommitPositionAndCodeReviewUrl(self):
-    testcases = [
-        {
-            'message':
-                'balabala...\n'
-                '\n'
-                'BUG=604502\n'
-                '\n'
-                'Review-Url: https://codereview.chromium.org/1927593004\n'
-                'Cr-Commit-Position: refs/heads/master@{#390254}\n',
-            'commit_position': 390254,
-            'code_review_url': 'https://codereview.chromium.org/1927593004',
-        },
-        {
-            'message':
-                'balabala...\n'
-                '\n'
-                'BUG=409934\n'
-                '\n'
-                'Review URL: https://codereview.chromium.org/547753003\n'
-                '\n'
-                'Cr-Commit-Position: refs/heads/master@{#293661}',
-            'commit_position': 293661,
-            'code_review_url': 'https://codereview.chromium.org/547753003',
-        },
-        {
-            'message':
-                'balabala...\n'
-                '\n'
-                'balabala...\n'
-                '\n'
-                'R=test4@chromium.org\n'
-                '\n'
-                'Review URL: https://codereview.chromium.org/469523002\n'
-                '\n'
-                'Cr-Commit-Position: refs/heads/master@{#289120}',
-            'commit_position': 289120,
-            'code_review_url': 'https://codereview.chromium.org/469523002',
-        },
-        {
-            'message': None,
-            'commit_position': None,
-            'code_review_url': None
-        }
-    ]
-
-    for testcase in testcases:
-      (commit_position,
-       code_review_url) = self.git_repo.ExtractCommitPositionAndCodeReviewUrl(
-           testcase['message'])
-      self.assertEqual(commit_position, testcase['commit_position'])
-      self.assertEqual(code_review_url, testcase['code_review_url'])
-
   def testEndingSlashInRepoUrl(self):
     git_repo1 = gitiles_repository.GitilesRepository(
         self.repo_url, self.http_client_for_git)
     self.assertEqual(self.repo_url, git_repo1.repo_url)
 
     git_repo2 = gitiles_repository.GitilesRepository(
         '%s/' % self.repo_url, self.http_client_for_git)
     self.assertEqual(self.repo_url, git_repo2.repo_url)
 
   def testMalformattedJsonReponse(self):
@@ skipping 59 matching lines @@
     source = self.git_repo.GetSource(path, git_revision)
     self.assertEqual(original_source, source)
 
   def testTimeConversion(self):
     datetime_with_timezone = 'Wed Jul 22 19:35:32 2014 +0400'
     expected_datetime = datetime(2014, 7, 22, 15, 35, 32)
     utc_datetime = self.git_repo._GetDateTimeFromString(datetime_with_timezone)
 
     self.assertEqual(expected_datetime, utc_datetime)
 
-  def testGetRevertedRevision(self):
-    message = (
-        'Revert of test1\n\nReason for revert:\nrevert test1\n\n'
-        'Original issue\'s description:\n> test 1\n>\n'
-        '> description of test 1.\n>\n> BUG=none\n> TEST=none\n'
-        '> R=test@chromium.org\n> TBR=test@chromium.org\n>\n'
-        '> Committed: https://chromium.googlesource.com/chromium/src/+/'
-        'c9cc182781484f9010f062859cda048afefefefe\n'
-        '> Cr-Commit-Position: refs/heads/master@{#341992}\n\n'
-        'TBR=test@chromium.org\nNOPRESUBMIT=true\nNOTREECHECKS=true\n'
-        'NOTRY=true\nBUG=none\n\n'
-        'Review URL: https://codereview.chromium.org/1278653002\n\n'
-        'Cr-Commit-Position: refs/heads/master@{#342013}\n')
-
-    reverted_revision = self.git_repo.GetRevertedRevision(message)
-    self.assertEqual('c9cc182781484f9010f062859cda048afefefefe',
-                     reverted_revision)
-
-  def testGetRevertedRevisionRevertOfRevert(self):
-    message = (
-        'Revert of Revert\n\nReason for revert:\nRevert of revert\n\n'
-        'Original issue\'s description:\n> test case of revert of revert\n>\n'
-        '> Reason for revert:\n> reason\n>\n> Original issue\'s description:\n'
-        '> > base cl\n> >\n> > R=kalman\n> > BUG=424661\n> >\n'
-        '> > Committed: https://crrev.com/34ea66b8ac1d56dadd670431063857ffdd\n'
-        '> > Cr-Commit-Position: refs/heads/master@{#326953}\n>\n'
-        '> TBR=test@chromium.org\n> NOPRESUBMIT=true\n'
-        '> NOTREECHECKS=true\n> NOTRY=true\n> BUG=424661\n>\n'
-        '> Committed: https://crrev.com/76a7e3446188256ca240dc31f78de29511a'
-        '2c322\n'
-        '> Cr-Commit-Position: refs/heads/master@{#327021}\n\n'
-        'TBR=test@chromium.org\nNOPRESUBMIT=true\n'
-        'NOTREECHECKS=true\nNOTRY=true\nBUG=424661\n\n'
-        'Review URL: https://codereview.chromium.org/1161773008\n\n'
-        'Cr-Commit-Position: refs/heads/master@{#332062}\n')
-
-    reverted_revision = self.git_repo.GetRevertedRevision(message)
-    self.assertEqual('76a7e3446188256ca240dc31f78de29511a2c322',
-                     reverted_revision)
-
-  def testGetRevertedRevisionNoRevertedCL(self):
-    message = (
-        'Test for not revert cl\n\n'
-        'TBR=test@chromium.org\nNOPRESUBMIT=true\n'
-        'NOTREECHECKS=true\nNOTRY=true\nBUG=424661\n\n'
-        'Review URL: https://codereview.chromium.org/1161773008\n\n'
-        'Cr-Commit-Position: refs/heads/master@{#332062}\n')
-
-    reverted_revision = self.git_repo.GetRevertedRevision(message)
-    self.assertIsNone(reverted_revision)
-
   def testGetCommitsBetweenRevisions(self):
     def _MockSendRequestForJsonResponse(*_):
       return {
           'log': [
               {'commit': '3'},
               {'commit': '2'},
               {'commit': '1'}]
       }
     self.mock(gitiles_repository.GitilesRepository,
         '_SendRequestForJsonResponse', _MockSendRequestForJsonResponse)
@@ skipping 80 matching lines @@
     changelogs = self.git_repo.GetChangeLogs('0', '2')
 
     self.assertEqual(len(changelogs), 2)
 
   def testGetWrappedGitRepositoryClass(self):
     repo = gitiles_repository.GitilesRepository(
         'http://repo_url', HttpClientForGit())
 
     self.assertEqual(repo.repo_url, 'http://repo_url')
     self.assertTrue(isinstance(repo.http_client, HttpClientForGit))