Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: appengine/findit/crash/findit.py

Issue 2480593002: [Predator] Move time_util from common/ to lib/, split code review related part to code_review_util (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import logging 6 import logging
7 7
8 from google.appengine.ext import ndb 8 from google.appengine.ext import ndb
9 9
10 from common import appengine_util 10 from common import appengine_util
11 from common import chrome_dependency_fetcher 11 from common import chrome_dependency_fetcher
12 from common import constants 12 from common import constants
13 from common import time_util
14 from crash.crash_report import CrashReport 13 from crash.crash_report import CrashReport
14 from lib import time_util
15 from model import analysis_status 15 from model import analysis_status
16 from model.crash.crash_config import CrashConfig 16 from model.crash.crash_config import CrashConfig
17 17
18 # TODO(http://crbug.com/659346): since most of our unit tests are 18 # TODO(http://crbug.com/659346): since most of our unit tests are
19 # FinditForFracas-specific, wrengr moved them to findit_for_chromecrash_test.py. 19 # FinditForFracas-specific, wrengr moved them to findit_for_chromecrash_test.py.
20 # However, now we're missing coverage for most of this file (due to the 20 # However, now we're missing coverage for most of this file (due to the
21 # buggy way coverage is computed). Need to add a bunch of new unittests 21 # buggy way coverage is computed). Need to add a bunch of new unittests
22 # to get coverage back up. 22 # to get coverage back up.
23 23
24 # TODO: this class depends on ndb stuff, and should therefore move to 24 # TODO: this class depends on ndb stuff, and should therefore move to
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 stacktrace = self.ParseStacktrace(model) 278 stacktrace = self.ParseStacktrace(model)
279 if stacktrace is None: 279 if stacktrace is None:
280 return None 280 return None
281 281
282 return self._predator.FindCulprit(CrashReport( 282 return self._predator.FindCulprit(CrashReport(
283 crashed_version = model.crashed_version, 283 crashed_version = model.crashed_version,
284 signature = model.signature, 284 signature = model.signature,
285 platform = model.platform, 285 platform = model.platform,
286 stacktrace = stacktrace, 286 stacktrace = stacktrace,
287 regression_range = model.regression_range)) 287 regression_range = model.regression_range))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698