Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2480583003: [Binding] Expose a function as a static method of V8Initializer (Closed)

Created:
4 years, 1 month ago by peria
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose a function messageHanlderInMainThread in V8Initializer.cpp as a static method of V8Initializer to be visible from other compile units. This function will be referred from V8 in its context serialization. BUG=636159 Committed: https://crrev.com/8607ed4014092c8fea4db5a35cea0cf3fd96dd03 Cr-Commit-Position: refs/heads/master@{#429825}

Patch Set 1 #

Patch Set 2 : Make it a static method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
peria
PTL
4 years, 1 month ago (2016-11-04 05:34:26 UTC) #3
haraken
Would you make it a static function of the V8Initializer class?
4 years, 1 month ago (2016-11-04 05:37:25 UTC) #4
peria
On 2016/11/04 05:37:25, haraken wrote: > Would you make it a static function of the ...
4 years, 1 month ago (2016-11-04 05:56:16 UTC) #6
haraken
LGTM
4 years, 1 month ago (2016-11-04 06:02:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480583003/20001
4 years, 1 month ago (2016-11-04 06:03:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 07:33:48 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8607ed4014092c8fea4db5a35cea0cf3fd96dd03 Cr-Commit-Position: refs/heads/master@{#429825}
4 years, 1 month ago (2016-11-04 07:35:52 UTC) #13
Yuki
4 years, 1 month ago (2016-11-04 08:35:32 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698