Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2480573002: GN: Fix build (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
vsm, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Fix build DDC needs another argument to make --help work. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/e4e7e28c7ff7958592462f137972bb810f2f0b8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M utils/dartdevc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 1 month ago (2016-11-03 21:47:12 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-03 21:49:11 UTC) #3
zra
Committed patchset #1 (id:1) manually as e4e7e28c7ff7958592462f137972bb810f2f0b8e (presubmit successful).
4 years, 1 month ago (2016-11-03 21:51:06 UTC) #5
rmacnak
4 years, 1 month ago (2016-11-03 21:51:07 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698