Issue 248053008: Proof of adoption in SkRecord::replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248053008: Proof of adoption in SkRecord::replace. (Closed)

Created:
6 years, 8 months ago by mtklein_C

Modified:
6 years, 8 months ago

Reviewers:
f(malita), mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Proof of adoption in SkRecord::replace. It used to be an unenforced requirement that callers take ownership of the command which was replaced when calling SkRecord::replace. Now we can enforce it, by splitting replace into two modes: - T* replace(i): always destroys the existing command for you - T* replace(i, proofOfAdoption): proofOfAdoption is checked to make sure the caller has adopted the existing command before replacing it. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14352

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -29 lines)			Patch
M	src/record/SkRecord.h	View	4 chunks	+27 lines, -10 lines	0 comments	Download
M	src/record/SkRecordOpts.cpp	View	6 chunks	+13 lines, -17 lines	0 comments	Download
M	src/record/SkRecords.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/248053008/1

6 years, 8 months ago (2014-04-24 13:47:41 UTC) #4

Message was sent while issue was closed.

Change committed as 14352

Expand Messages | Collapse Messages