Enable texture copy for webiew

Enable texture copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066
Committed: https://crrev.com/f9f2b720abc396410f2d56e53cba025d0b0b0912
Cr-Commit-Position: refs/heads/master@{#430702}

[tguilbert, 2016-11-07 22:29:39]

Patchset #1 (id:1) has been deleted

[tguilbert, 2016-11-07 22:30:10]

Description was changed from

==========
Pipe enable_texture_copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066
==========

to

==========
Enable texture copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066
==========

[tguilbert, 2016-11-07 22:30:31]

tguilbert@chromium.org changed reviewers:
+ liberato@chromium.org

[tguilbert, 2016-11-07 22:30:31]

PTAL!

Thanks,
Thomas

[liberato (no reviews please), 2016-11-07 22:35:31]

lgtm

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
File content/renderer/media/android/stream_texture_wrapper_impl.h (right):

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
content/renderer/media/android/stream_texture_wrapper_impl.h:46: bool
enable_texture_copy,
please add a line to document this.

[DaleCurtis, 2016-11-07 22:37:49]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-11-07 22:37:50]

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
File content/renderer/media/android/stream_texture_wrapper_impl.cc (right):

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
content/renderer/media/android/stream_texture_wrapper_impl.cc:103: if
(enable_texture_copy_)
multiline if needs {}

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:2815: bool enable_texture_copy =
Generally just inline if there's only one user. Use |render_thread| ?

[tguilbert, 2016-11-07 23:25:00]

tguilbert@chromium.org changed reviewers:
+ piman@chromium.org

[tguilbert, 2016-11-07 23:25:01]

PTAL :)

@piman, can you 1 line OWNERS review content/renderer/render_frame_impl.cc?

Thanks!
Thomas

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
File content/renderer/media/android/stream_texture_wrapper_impl.cc (right):

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
content/renderer/media/android/stream_texture_wrapper_impl.cc:103: if
(enable_texture_copy_)
On 2016/11/07 22:37:50, DaleCurtis wrote:
> multiline if needs {}

Oops, yes :) Done.

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
File content/renderer/media/android/stream_texture_wrapper_impl.h (right):

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/...
content/renderer/media/android/stream_texture_wrapper_impl.h:46: bool
enable_texture_copy,
On 2016/11/07 22:35:31, liberato wrote:
> please add a line to document this.

Done.

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2480523006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:2815: bool enable_texture_copy =
On 2016/11/07 22:37:50, DaleCurtis wrote:
> Generally just inline if there's only one user. Use |render_thread| ?

Done and done.

[piman, 2016-11-07 23:32:53]

lgtm

[tguilbert, 2016-11-08 18:41:16]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2016-11-08 18:41:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/2480523006/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-11-08 18:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 20:35:31]

Description was changed from

==========
Enable texture copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066
==========

to

==========
Enable texture copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066
==========

[commit-bot: I haz the power, 2016-11-08 20:35:32]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-08 20:41:40]

Description was changed from

==========
Enable texture copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066
==========

to

==========
Enable texture copy for webiew

This change adds texture copy scenario for webview, by setting the
apropriate metada data flag on the StreamTextureWrapper's frame.

BUG=628066

Committed: https://crrev.com/f9f2b720abc396410f2d56e53cba025d0b0b0912
Cr-Commit-Position: refs/heads/master@{#430702}
==========

[commit-bot: I haz the power, 2016-11-08 20:41:41]

Patchset 2 (id:??) landed as
https://crrev.com/f9f2b720abc396410f2d56e53cba025d0b0b0912
Cr-Commit-Position: refs/heads/master@{#430702}