Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2480523006: Enable texture copy for webiew (Closed)

Created:
4 years, 1 month ago by tguilbert
Modified:
4 years, 1 month ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable texture copy for webiew This change adds texture copy scenario for webview, by setting the apropriate metada data flag on the StreamTextureWrapper's frame. BUG=628066 Committed: https://crrev.com/f9f2b720abc396410f2d56e53cba025d0b0b0912 Cr-Commit-Position: refs/heads/master@{#430702}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M content/renderer/media/android/stream_texture_wrapper_impl.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/media/android/stream_texture_wrapper_impl.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download
M content/renderer/media/android/stream_texture_wrapper_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tguilbert
PTAL! Thanks, Thomas
4 years, 1 month ago (2016-11-07 22:30:31 UTC) #4
liberato (no reviews please)
lgtm https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/android/stream_texture_wrapper_impl.h File content/renderer/media/android/stream_texture_wrapper_impl.h (right): https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/android/stream_texture_wrapper_impl.h#newcode46 content/renderer/media/android/stream_texture_wrapper_impl.h:46: bool enable_texture_copy, please add a line to document ...
4 years, 1 month ago (2016-11-07 22:35:31 UTC) #5
DaleCurtis
https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/android/stream_texture_wrapper_impl.cc File content/renderer/media/android/stream_texture_wrapper_impl.cc (right): https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/android/stream_texture_wrapper_impl.cc#newcode103 content/renderer/media/android/stream_texture_wrapper_impl.cc:103: if (enable_texture_copy_) multiline if needs {} https://codereview.chromium.org/2480523006/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc ...
4 years, 1 month ago (2016-11-07 22:37:50 UTC) #7
tguilbert
PTAL :) @piman, can you 1 line OWNERS review content/renderer/render_frame_impl.cc? Thanks! Thomas https://codereview.chromium.org/2480523006/diff/20001/content/renderer/media/android/stream_texture_wrapper_impl.cc File content/renderer/media/android/stream_texture_wrapper_impl.cc ...
4 years, 1 month ago (2016-11-07 23:25:01 UTC) #9
piman
lgtm
4 years, 1 month ago (2016-11-07 23:32:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480523006/40001
4 years, 1 month ago (2016-11-08 18:41:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-08 20:35:32 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 20:41:41 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9f2b720abc396410f2d56e53cba025d0b0b0912
Cr-Commit-Position: refs/heads/master@{#430702}

Powered by Google App Engine
This is Rietveld 408576698