Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2480523003: Remove EventSender from HTMLSourceElement (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove EventSender from HTMLSourceElement BUG=624697 Committed: https://crrev.com/6f34e7c74ea016495fe3772da1a33062ffce3221 Cr-Commit-Position: refs/heads/master@{#430885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSourceElement.h View 4 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSourceElement.cpp View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
hiroshige
PTAL.
4 years, 1 month ago (2016-11-07 06:46:07 UTC) #7
tzik
lgtm
4 years, 1 month ago (2016-11-07 08:51:23 UTC) #8
haraken
LGTM
4 years, 1 month ago (2016-11-07 09:45:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480523003/1
4 years, 1 month ago (2016-11-09 06:08:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 07:54:34 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 07:56:45 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f34e7c74ea016495fe3772da1a33062ffce3221
Cr-Commit-Position: refs/heads/master@{#430885}

Powered by Google App Engine
This is Rietveld 408576698