Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2480523002: Enable inert top controls (URL bar) in stable. (Closed)

Created:
4 years, 1 month ago by bokan
Modified:
4 years, 1 month ago
Reviewers:
esprehn, Rick Byers
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable inert top controls (URL bar) in stable. Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 Committed: https://crrev.com/7f8de7508a3e8098ed174c59daa5b068808382f8 Cr-Commit-Position: refs/heads/master@{#429759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (13 generated)
bokan
Hey Rick, With https://codereview.chromium.org/2461463004/ landed I don't know of any other issues with this. I've ...
4 years, 1 month ago (2016-11-04 00:42:46 UTC) #10
Rick Byers
Just asked on the intent for a chromestatus entry. Otherwise LGTM - excited to see ...
4 years, 1 month ago (2016-11-04 00:52:25 UTC) #11
Rick Byers
Just asked on the intent for a chromestatus entry. Otherwise LGTM - excited to see ...
4 years, 1 month ago (2016-11-04 00:52:26 UTC) #12
bokan
On 2016/11/04 00:52:26, Rick Byers wrote: > Just asked on the intent for a chromestatus ...
4 years, 1 month ago (2016-11-04 01:17:57 UTC) #13
bokan
Ah, hadn't noticed this was in Source/platform :) +esprehn@ for OWNER
4 years, 1 month ago (2016-11-04 01:19:03 UTC) #15
esprehn
lgtm
4 years, 1 month ago (2016-11-04 01:21:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480523002/1
4 years, 1 month ago (2016-11-04 01:30:43 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 01:42:44 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7f8de7508a3e8098ed174c59daa5b068808382f8 Cr-Commit-Position: refs/heads/master@{#429759}
4 years, 1 month ago (2016-11-04 01:45:10 UTC) #22
Rick Byers
On 2016/11/04 01:19:03, bokan wrote: > Ah, hadn't noticed this was in Source/platform :) +esprehn@ ...
4 years, 1 month ago (2016-11-04 13:22:55 UTC) #23
bokan
On 2016/11/04 13:22:55, Rick Byers wrote: > On 2016/11/04 01:19:03, bokan wrote: > > Ah, ...
4 years, 1 month ago (2016-11-04 13:30:11 UTC) #24
Rick Byers
4 years, 1 month ago (2016-11-04 13:47:10 UTC) #25
Message was sent while issue was closed.
On 2016/11/04 13:30:11, bokan wrote:
> On 2016/11/04 13:22:55, Rick Byers wrote:
> > On 2016/11/04 01:19:03, bokan wrote:
> > > Ah, hadn't noticed this was in Source/platform :) +esprehn@ for OWNER
> > 
> > For the record, my WebKit/OWNERS was good enough in this case :-)
> 
> Ah, the chromite butler extension that shows approvals doesn't know about that
> file.

I think we discovered that it doesn't understand the "file://" include syntax it
uses.  That's fine - I don't think API_OWNERS should generally be thought of as
uber-reviewers appropriate to review any change anyway (I'm certainly not - lots
of stuff I don't know well enough to review).

Powered by Google App Engine
This is Rietveld 408576698