|
|
DescriptionEnable inert top controls (URL bar) in stable.
Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4
BUG=428132
Committed: https://crrev.com/7f8de7508a3e8098ed174c59daa5b068808382f8
Cr-Commit-Position: refs/heads/master@{#429759}
Patch Set 1 #
Messages
Total messages: 25 (13 generated)
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Description was changed from ========== Enable inert top controls (URL bar) in stable. BUG=428132 ========== to ========== Enable inert top controls (URL bar) in stable. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable inert top controls (URL bar) in stable. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 ========== to ========== Enable inert top controls (URL bar) in stable. Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bokan@chromium.org changed reviewers: + rbyers@chromium.org
bokan@chromium.org changed reviewers: - rbyers@chromium.org
bokan@chromium.org changed reviewers: + rbyers@chromium.org
Hey Rick, With https://codereview.chromium.org/2461463004/ landed I don't know of any other issues with this. I've posted on the old Intent-to-Ship I sent out long ago but since I already had the 3 lgtm's then, and I haven't gotten any replies to the contrary, I'd like to ship this. Sound good?
Just asked on the intent for a chromestatus entry. Otherwise LGTM - excited to see this ship!
Just asked on the intent for a chromestatus entry. Otherwise LGTM - excited to see this ship!
On 2016/11/04 00:52:26, Rick Byers wrote: > Just asked on the intent for a chromestatus entry. > > Otherwise LGTM - excited to see this ship! Done.
bokan@chromium.org changed reviewers: + esprehn@chromium.org
Ah, hadn't noticed this was in Source/platform :) +esprehn@ for OWNER
lgtm
The CQ bit was checked by bokan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable inert top controls (URL bar) in stable. Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 ========== to ========== Enable inert top controls (URL bar) in stable. Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable inert top controls (URL bar) in stable. Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 ========== to ========== Enable inert top controls (URL bar) in stable. Approval to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 BUG=428132 Committed: https://crrev.com/7f8de7508a3e8098ed174c59daa5b068808382f8 Cr-Commit-Position: refs/heads/master@{#429759} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7f8de7508a3e8098ed174c59daa5b068808382f8 Cr-Commit-Position: refs/heads/master@{#429759}
Message was sent while issue was closed.
On 2016/11/04 01:19:03, bokan wrote: > Ah, hadn't noticed this was in Source/platform :) +esprehn@ for OWNER For the record, my WebKit/OWNERS was good enough in this case :-)
Message was sent while issue was closed.
On 2016/11/04 13:22:55, Rick Byers wrote: > On 2016/11/04 01:19:03, bokan wrote: > > Ah, hadn't noticed this was in Source/platform :) +esprehn@ for OWNER > > For the record, my WebKit/OWNERS was good enough in this case :-) Ah, the chromite butler extension that shows approvals doesn't know about that file.
Message was sent while issue was closed.
On 2016/11/04 13:30:11, bokan wrote: > On 2016/11/04 13:22:55, Rick Byers wrote: > > On 2016/11/04 01:19:03, bokan wrote: > > > Ah, hadn't noticed this was in Source/platform :) +esprehn@ for OWNER > > > > For the record, my WebKit/OWNERS was good enough in this case :-) > > Ah, the chromite butler extension that shows approvals doesn't know about that > file. I think we discovered that it doesn't understand the "file://" include syntax it uses. That's fine - I don't think API_OWNERS should generally be thought of as uber-reviewers appropriate to review any change anyway (I'm certainly not - lots of stuff I don't know well enough to review). |