MD Settings: Add Import Bookmarks Dialog Strings

MD Settings: Add Import Bookmarks Dialog Strings

Straight copy of the strings from Options to Settings. The IDS
constants have been renamed.

BUG=659259
Committed: https://crrev.com/1287354883d7254210f53a13ab7fde856cad3661
Cr-Commit-Position: refs/heads/master@{#429681}

[tommycli, 2016-11-03 17:48:41]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 17:49:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-03 17:53:07]

tommycli@chromium.org changed reviewers:
+ hcarmona@chromium.org

[tommycli, 2016-11-03 17:53:08]

hcarmona: PTAL, thanks!

https://codereview.chromium.org/2480473002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2480473002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:2144: <!-- Android uses custom UI for Bookmark
importing -->
Taken from generated_resources.grd. IDS constants renamed slightly, and strings
have been reordered.

Descriptions and string values unchanged.

https://codereview.chromium.org/2480473002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2480473002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:736:
LocalizedString localized_strings[] = {
taken directly from
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/import_d...

[commit-bot: I haz the power, 2016-11-03 18:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:59:14]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-11-03 19:09:16]

Should we be adding strings that we're not using yet?

[tommycli, 2016-11-03 19:17:16]

On 2016/11/03 19:09:16, Hector Carmona wrote:
> Should we be adding strings that we're not using yet?

Well - alternatively I could merge this patch with the patch that actually uses
these strings (once it's written)... I just separated them for ease of review.

We are definitively going to use these strings though. It's a Dev blocker, so we
can't launch without using these strings.

[tommycli, 2016-11-03 19:20:22]

On 2016/11/03 19:17:16, tommycli wrote:
> On 2016/11/03 19:09:16, Hector Carmona wrote:
> > Should we be adding strings that we're not using yet?
> 
> Well - alternatively I could merge this patch with the patch that actually
uses
> these strings (once it's written)... I just separated them for ease of review.
> 
> We are definitively going to use these strings though. It's a Dev blocker, so
we
> can't launch without using these strings.

In a word - Yes, I think we should add these strings since we have a definitive
plan to use them (soon).

[hcarmona, 2016-11-03 19:30:20]

On 2016/11/03 19:20:22, tommycli wrote:
> On 2016/11/03 19:17:16, tommycli wrote:
> > On 2016/11/03 19:09:16, Hector Carmona wrote:
> > > Should we be adding strings that we're not using yet?
> > 
> > Well - alternatively I could merge this patch with the patch that actually
> uses
> > these strings (once it's written)... I just separated them for ease of
review.
> > 
> > We are definitively going to use these strings though. It's a Dev blocker,
so
> we
> > can't launch without using these strings.
> 
> In a word - Yes, I think we should add these strings since we have a
definitive
> plan to use them (soon).

SG, LGTM

[tommycli, 2016-11-03 20:05:43]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:06:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:11:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 20:14:00]

Description was changed from

==========
MD Settings: Add Import Bookmarks Dialog Strings

Straight copy of the strings from Options to Settings. The IDS
constants have been renamed.

BUG=659259
==========

to

==========
MD Settings: Add Import Bookmarks Dialog Strings

Straight copy of the strings from Options to Settings. The IDS
constants have been renamed.

BUG=659259

Committed: https://crrev.com/1287354883d7254210f53a13ab7fde856cad3661
Cr-Commit-Position: refs/heads/master@{#429681}
==========

[commit-bot: I haz the power, 2016-11-03 20:14:01]

Patchset 1 (id:??) landed as
https://crrev.com/1287354883d7254210f53a13ab7fde856cad3661
Cr-Commit-Position: refs/heads/master@{#429681}