Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 248043003: Check in the pre-built ICU data for Android (Closed)

Created:
6 years, 8 months ago by jungshik at Google
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Check in the pre-built ICU data files for Android - Update brkitr.patch to apply to ICU 52. ICU 52 has the CJK segmenter built-in. Fortunately, we just have to change the brkitr data without touching the code. - Update patch_locale.sh for additional data trimming (calendar and zone - exemplar cities). - Apply the two patches locally (the result is not landed in the tree) and build the icu data (icudtl.dat and icudtl_dat.S). The size of icudtl.dat with zip compression increased by 125kB (1,998,805 vs 1,870,219) and the uncompressed icudtl.dat got bigger by 463kB (6,049,360 vs 5,575,648) BUG=132145 TEST=None R=andrewhayden@chromium.org, wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265785

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -78 lines) Patch
M icu52.android/README.chromium View 1 2 chunks +14 lines, -7 lines 0 comments Download
A + icu52.android/android/brkitr.patch View 1 2 chunks +66 lines, -70 lines 0 comments Download
A icu52.android/android/icudtl.dat View 1 Binary file 0 comments Download
A + icu52.android/android/patch_locale.sh View 1 2 chunks +60 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
Can you take a look? (I'll update TEST line). I tried hard to minimize the ...
6 years, 8 months ago (2014-04-23 00:29:17 UTC) #1
jungshik at Google
BTW, don't be confused by 'icu52.android' in the path. This change will get landed in ...
6 years, 8 months ago (2014-04-23 00:33:24 UTC) #2
Xianzhu
lgtm
6 years, 8 months ago (2014-04-23 01:48:19 UTC) #3
Andrew Hayden (chromium.org)
LGTM. I have some errata to add for the instructions in the README, but I ...
6 years, 8 months ago (2014-04-23 11:38:09 UTC) #4
jungshik at Google
6 years, 8 months ago (2014-04-24 00:16:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r265785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698