DevTools: Use CodeMirror syntax highlighting to improve JS autocomplete

third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 WebInspector.JavaScriptAutocomplete = {};
 
 /**
  * @param {!Element} proxyElement
  * @param {!Range} wordRange
  * @param {boolean} force
  * @param {function(!Array.<string>, number=)} completionsReadyCallback
  */
 WebInspector.JavaScriptAutocomplete.completionsForTextPromptInCurrentContext = function(proxyElement, wordRange, force, completionsReadyCallback) {
   var expressionRange = wordRange.cloneRange();
   expressionRange.collapse(true);
   expressionRange.setStartBefore(proxyElement);
   WebInspector.JavaScriptAutocomplete.completionsForTextInCurrentContext(expressionRange.toString(), wordRange.toString(), force)
     .then(completionsReadyCallback);
 };
 
 /**
  * @param {string} text
  * @param {string} query
  * @param {boolean=} force
+ * @param {string=} tokenType
  * @return {!Promise<!Array<string>>}
  */
-WebInspector.JavaScriptAutocomplete.completionsForTextInCurrentContext = function(text, query, force) {
+WebInspector.JavaScriptAutocomplete.completionsForTextInCurrentContext = function(text, query, force, tokenType) {
+  var excludedTokens = new Set(['js-comment', 'js-string-2']);
+  if (!text.endsWith('['))

[einbinder, 2016/11/07 23:04:48]

If the user is typing window["docu then we want to provide completions for
"document" even though the current token is js-string.

+    excludedTokens.add('js-string');
+  if (excludedTokens.has(tokenType))
+    return Promise.resolve([]);
+
   var index;
   var stopChars = new Set(' =:({;,!+-*/&|^<>`'.split(''));
   for (index = text.length - 1; index >= 0; index--) {
     // Pass less stop characters to rangeOfWord so the range will be a more complete expression.
     if (stopChars.has(text.charAt(index)))
       break;
   }
   var clippedExpression = text.substring(index + 1);
   var bracketCount = 0;
 
@@ skipping 245 matching lines @@
       caseSensitivePrefix.push(prop);
     else if (property.toLowerCase().startsWith(query.toLowerCase()))
       caseInsensitivePrefix.push(prop);
     else if (property.indexOf(query) !== -1)
       caseSensitiveAnywhere.push(prop);
     else
       caseInsensitiveAnywhere.push(prop);
   }
   return caseSensitivePrefix.concat(caseInsensitivePrefix).concat(caseSensitiveAnywhere).concat(caseInsensitiveAnywhere);
 };