DevTools: Use CodeMirror syntax highlighting to improve JS autocomplete

DevTools: Use CodeMirror syntax highlighting to improve JS autocomplete

This patch uses CodeMirror tokens to avoid giving suggestions when the
user is in a comment, string, or regular expression literal.

BUG=663040
Committed: https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e
Cr-Commit-Position: refs/heads/master@{#431344}

[einbinder, 2016-11-07 22:09:44]

einbinder@chromium.org changed reviewers:
+ luoe@chromium.org

[einbinder, 2016-11-07 22:09:44]

ptal

[einbinder, 2016-11-07 23:04:48]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-11-07 23:04:49]

https://codereview.chromium.org/2480423002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
(right):

https://codereview.chromium.org/2480423002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:30:
if (!text.endsWith('['))
If the user is typing window["docu then we want to provide completions for
"document" even though the current token is js-string.

[einbinder, 2016-11-07 23:06:06]

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html
(right):

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html:61:
() => testCompletions("", "", ["window"], true),
Bonus test of forced/unforced completions.

[lushnikov, 2016-11-08 02:52:54]

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
(right):

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:29:
var excludedTokens = new Set(['js-comment', 'js-string-2']);
Let's have this code either in TextEditorAutocompleteController or ConsolePrompt

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
(right):

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js:238:
var tokenType = (token && token.type) || '';
can we bail out autocomplete right here, in the very beginning?

[einbinder, 2016-11-10 00:18:31]

ptal

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
(right):

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:29:
var excludedTokens = new Set(['js-comment', 'js-string-2']);
On 2016/11/08 at 02:52:54, lushnikov wrote:
> Let's have this code either in TextEditorAutocompleteController or
ConsolePrompt

Moved it to ConsolePrompt.

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
(right):

https://codereview.chromium.org/2480423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js:238:
var tokenType = (token && token.type) || '';
On 2016/11/08 at 02:52:54, lushnikov wrote:
> can we bail out autocomplete right here, in the very beginning?

TextEditorAutocomplete shouldn't know what JavaScript is.

https://codereview.chromium.org/2480423002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html
(right):

https://codereview.chromium.org/2480423002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html:16:
var consoleEditor;
I changed this test to go through the ConsolePrompt, instead of directly going
to JavaScriptAutocomplete.

[einbinder, 2016-11-10 00:18:35]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 00:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-10 03:02:04]

lgtm

https://codereview.chromium.org/2480423002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
(right):

https://codereview.chromium.org/2480423002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js:113:
* @param {string=} tokenType
currentTokenType

[einbinder, 2016-11-10 18:35:14]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-11-10 18:35:15]

https://codereview.chromium.org/2480423002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
(right):

https://codereview.chromium.org/2480423002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js:113:
* @param {string=} tokenType
On 2016/11/10 at 03:02:04, lushnikov wrote:
> currentTokenType

Done.

[einbinder, 2016-11-10 18:35:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2480423002/#ps80001
(title: "CurrentTokenType")

[commit-bot: I haz the power, 2016-11-10 18:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:50:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-10 21:00:07]

Description was changed from

==========
DevTools: Use CodeMirror syntax highlighting to improve JS autocomplete

This patch uses CodeMirror tokens to avoid giving suggestions when the
user is in a comment, string, or regular expression literal.

BUG=663040
==========

to

==========
DevTools: Use CodeMirror syntax highlighting to improve JS autocomplete

This patch uses CodeMirror tokens to avoid giving suggestions when the
user is in a comment, string, or regular expression literal.

BUG=663040

Committed: https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e
Cr-Commit-Position: refs/heads/master@{#431344}
==========

[commit-bot: I haz the power, 2016-11-10 21:00:08]

Patchset 5 (id:??) landed as
https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e
Cr-Commit-Position: refs/heads/master@{#431344}