Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2480353008: cros system menu - fix back and settings buttons in IME detailed view. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, Azure Wei
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros system menu - fix back and settings buttons in IME detailed view. BUG=663792 Committed: https://crrev.com/b63424084b0db324a1b44b27a2493c4f5ee39b0d Cr-Commit-Position: refs/heads/master@{#431133}

Patch Set 1 #

Patch Set 2 : finality #

Patch Set 3 : lockdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/tray/tray_details_view.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Evan Stade
4 years, 1 month ago (2016-11-10 00:29:04 UTC) #2
tdanderson
LGTM
4 years, 1 month ago (2016-11-10 01:20:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480353008/40001
4 years, 1 month ago (2016-11-10 01:42:32 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-10 01:48:41 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 01:51:45 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b63424084b0db324a1b44b27a2493c4f5ee39b0d
Cr-Commit-Position: refs/heads/master@{#431133}

Powered by Google App Engine
This is Rietveld 408576698