Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2480343002: [ic] Drop TimerEventScopes from *IC_Miss runtime functions (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Drop TimerEventScopes from *IC_Miss runtime functions This is mostly a performance experiment. If it provides no speedup, it can be reverted to keep IC miss events in timeline plots. Otherwise, the RuntimeCallStats system is the replacement tool for investigating performance issues related to IC misses. This effectively reverts 1f8adc15 / r21736. Committed: https://crrev.com/eca64a2a8c7b018970b84c3ff75cd98660184d5a Cr-Commit-Position: refs/heads/master@{#40893}

Patch Set 1 #

Total comments: 1

Patch Set 2 : drop debugging leftover #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -253 lines) Patch
M src/ic/ic.cc View 12 chunks +0 lines, -12 lines 0 comments Download
M src/log.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/mjsunit.js View 1 chunk +6 lines, -2 lines 0 comments Download
M test/mjsunit/tools/profviz.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/tools/profviz-test.default View 1 5 chunks +230 lines, -230 lines 0 comments Download
M tools/profviz/composer.js View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/profviz/stdio.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jakob Kummerow
PTAL. https://codereview.chromium.org/2480343002/diff/1/test/mjsunit/tools/profviz-test.default File test/mjsunit/tools/profviz-test.default (right): https://codereview.chromium.org/2480343002/diff/1/test/mjsunit/tools/profviz-test.default#newcode451 test/mjsunit/tools/profviz-test.default:451: "set object 439 rect from 22.2675, 18.83 to ...
4 years, 1 month ago (2016-11-07 16:59:51 UTC) #2
Yang
On 2016/11/07 16:59:51, Jakob Kummerow wrote: > PTAL. > > https://codereview.chromium.org/2480343002/diff/1/test/mjsunit/tools/profviz-test.default > File test/mjsunit/tools/profviz-test.default (right): ...
4 years, 1 month ago (2016-11-08 10:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480343002/1
4 years, 1 month ago (2016-11-08 10:12:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/7489) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-08 10:28:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480343002/20001
4 years, 1 month ago (2016-11-10 12:41:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 13:10:12 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eca64a2a8c7b018970b84c3ff75cd98660184d5a
Cr-Commit-Position: refs/heads/master@{#40893}

Powered by Google App Engine
This is Rietveld 408576698