Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2480333002: GN: Take asan default from an environment variable (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Bill Hesse, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Take asan default from an environment variable If DART_USE_ASAN is defined, then the GN build will have ASAN enabled after a 'gclient runhooks' R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/02cb4a0003f5df0580a760f2366896807a1670dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M tools/gn.py View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
zra
4 years, 1 month ago (2016-11-07 16:56:31 UTC) #4
Bill Hesse
lgtm
4 years, 1 month ago (2016-11-07 16:58:47 UTC) #5
zra
4 years, 1 month ago (2016-11-07 17:01:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02cb4a0003f5df0580a760f2366896807a1670dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698