Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2480323002: Revert of Compile fuzzer sources in standalone builds. (Closed)

Created:
4 years, 1 month ago by npm
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Compile fuzzer sources in standalone builds. (patchset #3 id:40001 of https://codereview.chromium.org/2480043002/ ) Reason for revert: Breaking the tree: https://build.chromium.org/p/client.pdfium/builders/windows_xfa_32/builds/619/steps/compile%20with%20ninja/logs/stdio Original issue's description: > Compile fuzzer sources in standalone builds. > > - Add a template for fuzzers to remove redundancy. > - Sort fuzzers in alphabetical order. > > Committed: https://pdfium.googlesource.com/pdfium/+/470b5fa8f8dbfd2aa702d9d8cfdc03a7b486b374 TBR=dsinclair@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/9adabf8867243579ce9cf8969707a9b919065090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -101 lines) Patch
M BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 2 chunks +221 lines, -94 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
npm
Created Revert of Compile fuzzer sources in standalone builds.
4 years, 1 month ago (2016-11-07 16:33:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480323002/1
4 years, 1 month ago (2016-11-07 16:34:02 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 16:34:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/9adabf8867243579ce9cf8969707a9b91906...

Powered by Google App Engine
This is Rietveld 408576698