Fix links in tutorial

chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Introduces users to ChromeVox.
  */
 
 goog.provide('Tutorial');
 
@@ skipping 160 matching lines @@
         element.setAttribute('tabindex', -1);
         if (!focus)
           focus = element;
       } else if (pageElement.list) {
         element = document.createElement('ul');
         this.buildDom_(pageElement.items, element);
       } else if (pageElement.listItem) {
         element = document.createElement('li');
       } else if (pageElement.link) {
         element = document.createElement('a');
-        element.href = pageElement.link;

[dmazzoni, 2016/11/07 23:55:35]

I think you should add href='#' or role="link" and tabIndex=0, because otherwise
technically an "a" element with no href isn't even a link

[David Tseng, 2016/11/08 02:47:24]

Strange it worked for me as I definitely moved to the links via search+l in
order to verify that they did indeed respond to click.

Anyway, converted to role link with tabindex 0 and new-style event listeners.

+        element.onclick = function() {

[dmazzoni, 2016/11/07 23:55:35]

return false, or stopPropagation/preventDefault?

[David Tseng, 2016/11/08 02:47:24]

Ok, explicitly returning false 

+          Panel.closeMenusAndRestoreFocus();
+          chrome.windows.create({url: pageElement.link});
+        };
         element.target = '_blank';
       } else {
         element = document.createElement('p');
       }
       if (text)
         element.innerText = text;
       container.appendChild(element);
     }
     if (focus)
       focus.focus();
   },
 
   /** @private */
   finalizeDom_: function() {
     var disableNext = this.page == (Tutorial.PAGES.length - 1);
     var disablePrevious = this.page == 0;
     $('tutorial_next').setAttribute('aria-disabled', disableNext);
     $('tutorial_previous').setAttribute('aria-disabled', disablePrevious);
   },
 
   get page() {
     return this.page_;
   },
 
   set page(val) {
     this.page_ = val;
     sessionStorage['tutorial_page_pos'] = this.page_;
   }
 };